perf: use async fs & crypto methods #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
sangaman
force-pushed
the
no-blocking
branch
from
4568680 to
0ec10a1
Compare
|
There's definitely no excuse for blocking the thread on Nodejs, since it was created for async I/O, and so all the libs support that. I think we introduced some sync version usages because we needed it in the constructor, but this should be avoided as well. Looks great! |
moshababo
approved these changes
Nov 16, 2018
ghost
reviewed
Nov 17, 2018
This replaces all synchronous calls to the NodeJS `fs` and `crypto.randomBytes` methods with asynchronous calls. This improves performance by preventing blocking of the event loop.
This creates a unit test suite for the node key module. Currently the only test verifies that it will generate a valid node key.
sangaman
force-pushed
the
no-blocking
branch
from
0ec10a1 to
03fdd41
Compare
sangaman
added a commit
that referenced
this pull request
Nov 19, 2018
This fixes a bug introduced in #672 whereby the lnd clients are not properly initializing. That PR removed synchronous calls to methods that had asynchronous alternatives, which necessitated moving code from the synchronous `LndClient` constructor to an asynchronous init method. Included in the code that was moved was logic to determine whether to change the client's status from the default value of `Disabled`. This impacted the xud initialization procedure which would only attempt to initialize (or previously verify a connection for) an lnd client that was not disabled. This PR creates a new `NotInitialized` status as the default to reflect the status of a newly created client. It gets changed when the `init` method is called.
sangaman
added a commit
that referenced
this pull request
Nov 19, 2018
This fixes a bug introduced in #672 whereby the lnd clients are not properly initializing. That PR removed synchronous calls to methods that had asynchronous alternatives, which necessitated moving code from the synchronous `LndClient` constructor to an asynchronous init method. Included in the code that was moved was logic to determine whether to change the client's status from the default value of `Disabled`. This impacted the xud initialization procedure which would only attempt to initialize (or previously verify a connection for) an lnd client that was not disabled. This PR creates a new `NotInitialized` status as the default to reflect the status of a newly created client. It gets changed when the `init` method is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces all synchronous calls to the NodeJS
fsandcrypto.randomBytesmethods with asynchronous calls. This improves performance by preventing blocking of the event loop. I was inspired after reading Don't Block the Event Loop. Most of the benefit is during startup/initialization, but there should also be a small benefit when proposing swaps which should happen quite frequently.I also added a test suite for NodeKey.ts, I was primarily motivated by having a quick way to test that the async
crypto.randomBytescall was working but it would also be good expand in the future.