refactor(orderbook): set localId to global id #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies `Orderbook.stampOwnOrder` to set `localId` to global `id` in case `localId` is not provided.
ghost
self-assigned this
ghost
mentioned this pull request
ghost
force-pushed
the
refactor/localid-default
branch
from
cb6de88 to
73022ab
Compare
sangaman
approved these changes
Nov 13, 2018
ghost
force-pushed
the
refactor/localid-default
branch
from
73022ab to
51ae63e
Compare
ImmanuelSegol
added a commit
that referenced
this pull request
Jan 19, 2019
sangaman
pushed a commit
that referenced
this pull request
Aug 20, 2019
Closes #667. Co-authored-by: rsercano <[email protected]>
sangaman
pushed a commit
that referenced
this pull request
Aug 20, 2019
Closes #667. Co-authored-by: rsercano <[email protected]>
sangaman
added a commit
that referenced
this pull request
Aug 20, 2019
feat: listtrades grpc command #667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we:
Orderbook.stampOwnOrderto setlocalIdto globalidin caselocalIdis not providedOrderbook.stampOwnOrderCloses #223.