feat(OrderBook.ts) persist trades to DB #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
sangaman
requested changes
Nov 11, 2018
sangaman
requested changes
Nov 14, 2018
ghost
reviewed
Nov 14, 2018
sangaman
reviewed
Nov 14, 2018
sangaman
reviewed
Nov 16, 2018
There was a problem hiding this comment.
I pulled this down and ran a quick sanity test and it worked fine, but I noticed we're not persisting trades on swap.paid which marks a successful trade of a remote peer filling one of our orders. I'm going to just fix these up and merge to get in the release.
Edit: Never mind actually, I will just remove an unused import for now and then open a separate PR.
sangaman
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: This addresses most of #608 but not the case where a swap is initiated by a remote peer.