feat: enhance simulation test README #2001
Conversation
| If you still have issues, make sure docker swarm is initialized and you have typescript installed: | ||
| ``` | ||
| docker swarm init | ||
| npm install -g typescript |
There was a problem hiding this comment.
I don't have typescript installed globally but afaik that hasn't caused me any issues, is there a reason this would rely on the global typescript installation rather than the typescript dependency within this xud project?
There was a problem hiding this comment.
Not sure, added it because of #1995 (comment) and I believe it fixed a ts error I got once.
There was a problem hiding this comment.
I later verified that indeed it's not required if you run npm install (which you must do anyway).
See here: #1995 (comment)
test/simulation/README.md
Outdated
| cd xud | ||
| npm run test:sim:clean | ||
| npm run test:sim:clean:indra | ||
| rm -rf ./test/simulation/temp |
There was a problem hiding this comment.
The only things in the temp folder is logs and the indra folder (which is cleaned in the above step), so I'm not sure whether we need to include both steps here, but I suppose it doesn't hurt.
There was a problem hiding this comment.
Moved to the second part.
sangaman
added
the
documentation
|
But more importantly: can you get the tests to pass locally now? @sangaman Honestly, the time Moshe and I invested here was mainly to find steps and a environment (versions) for tests to pass for you. @erkarl @michael1011 @moshababo and I can get tests to pass reliably by now. |
|
Well I guess Daniel will let us know if tests still don't work for him. |
ghost
deleted the
Still no, unfortunately, tried all the steps here and am getting the same old: |
Closes #1995