Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: propagating nodes on database if initDB true even DB is filled #1907

Merged
merged 1 commit into from
Sep 24, 2020
Merged

fix: propagating nodes on database if initDB true even DB is filled #1907

merged 1 commit into from
Sep 24, 2020

Conversation

rsercano
Copy link
Collaborator

attemps to resolve #1645

@rsercano rsercano added the database Database related issues label Sep 19, 2020
@rsercano rsercano self-assigned this Sep 19, 2020
sangaman
sangaman previously requested changes Sep 22, 2020
View reviewed changes
Copy link
Collaborator

@sangaman sangaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should work to add any missing seed nodes to the database. I just noted one change to ensure we aren't calling bulkCreate every time we start xud even when there are no nodes to add.

@rsercano rsercano force-pushed the fix/propagate-newly-added-nodes branch from 3bc04ea to b90fdb1 Compare September 22, 2020 10:15
@rsercano rsercano requested a review from sangaman September 22, 2020 10:15
@raladev raladev merged commit 246136e into master Sep 24, 2020
@kilrau kilrau mentioned this pull request Sep 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raladev raladev raladev approved these changes

@sangaman sangaman Awaiting requested review from sangaman

Assignees

@rsercano rsercano

Labels
database Database related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seed node updates don't propagate on existing db
3 participants
@rsercano @sangaman @raladev