fix(connext): avoid scientific notation for amount #1905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way we convert numbers to strings when building requests to send to the Connext client by using
toLocaleString
instead oftoString
to avoid representing large numbers with scientific notation.This should help with issues we've faced using toknes that deal with larger quantities like DAI.
An example of how
toLocaleString
compares withtoString
as well asbigint
: