fix: listorders limit displays first orders instead of last #1883
Conversation
raladev
changed the title
|
ACK, #1881 is a bug! |
There was a problem hiding this comment.
The root cause here as I see it is that we're sorting our orders backwards from what I would expect. The buy orders increase in price while the sell orders decrease in price. I'd expect the first element in each array (buy and sell) to be the "best" price. Therefore, taking the first n orders from the array indeed gives us the n worst orders instead of n best. Our cli tool is designed with this "backwards" order in mind, which is why they display properly.
This fix looks good, but I'd be inclined to revisit this issue and make the order sorting go from best to worst (and change xucli accordingly). I can see it causing more confusion down the road, although it's a breaking change so we'd need to make sure it doesn't cause any issues with arby.
* Change slice for limit parameter * fix test for listorders limit resolves reviews
ghost
deleted the
Fix of #1881, but need ACK from @kilrau that it is a bug :)