Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwapRecovery stops monitoring swap after xud restart #1818

Closed
kilrau opened this issue Aug 17, 2020 · 2 comments
Closed

SwapRecovery stops monitoring swap after xud restart #1818

kilrau opened this issue Aug 17, 2020 · 2 comments
Assignees
@sangaman
Labels
duplicate This issue or pull request already exists P1 top priority security securing xud from unauthorized actions swaps

Comments

@kilrau
Copy link
Contributor

kilrau commented Aug 17, 2020 •
edited
Loading

This is from makers perspective. What happened: taker filled our sell eth/btc order, taker's eth side needed to be collateralized which caused the connext eth payment to timeout (60s) as well as the xud swap (90s) and the eth payment was never sent.

Due to lack of #1708, xud currently doesn't know about the status of the connext htlc, thus assumes it's up and throws the swap into swap recovery. So far correct.

But then when I went ahead and restarted xud, swap recovery was not monitoring the swap anymore. Checking the xud db, the swap state changed to 1 (errored). We need to find out what changed the swap state to 1 and prevent that from happening so that swap recovery continues monitoring the swap.

image

xud log: https://paste.ubuntu.com/p/Y8ZzWhwZJk/
@kilrau kilrau added P2 mid priority swaps security securing xud from unauthorized actions labels Aug 17, 2020
@kilrau kilrau added P1 top priority and removed P2 mid priority labels Aug 17, 2020
@raladev
Copy link
Contributor

raladev commented Aug 17, 2020

looks like duplicate of #1799

@kilrau kilrau mentioned this issue Aug 17, 2020
Closed
@sangaman sangaman added the duplicate This issue or pull request already exists label Aug 18, 2020
@sangaman
Copy link
Collaborator

looks like duplicate of #1799

Agreed, closing as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaman sangaman

Labels
duplicate This issue or pull request already exists P1 top priority security securing xud from unauthorized actions swaps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sangaman @kilrau @raladev