fix: add :: to selfaddress detection
#1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangaman
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Good catch as this was missing as the counterpart to 0.0.0.0. I think though logically speaking this should maybe be a separate check since 0.0.0.0 isn't exactly a "self" address it's a non-routable catch-all address that could technically be "advertised" by a non-self node. But for a quick fix this is good and makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ipv6 version
::of0.0.0.0to the self address detection of xud/xucli. Stumbled upon in ExchangeUnion/xud-docker#419 (comment).