fix: alias missing in streamorders (#1725) (#1962)

Author: rsercano

Diff for: lib/grpc/GrpcService.ts

@@ -880,10 +880,10 @@ class GrpcService {
 
     const cancelled$ = getCancelled$(call);
 
-    this.service.subscribeOrders(call.request.toObject(), (order?: Order, orderRemoval?: OrderPortion) => {
+    this.service.subscribeOrders(call.request.toObject(), (order?: ServiceOrder, orderRemoval?: OrderPortion) => {
       const orderUpdate = new xudrpc.OrderUpdate();
       if (order) {
-        orderUpdate.setOrder(createOrder(order));
+        orderUpdate.setOrder(createServiceOrder(order));
       } else if (orderRemoval) {
         const grpcOrderRemoval = new xudrpc.OrderRemoval();
         grpcOrderRemoval.setPairId(orderRemoval.pairId);

Diff for: lib/service/Service.ts

@@ -699,17 +699,17 @@ class Service extends EventEmitter {
    */
   public subscribeOrders = (
     args: { existing: boolean },
-    callback: (order?: Order, orderRemoval?: OrderPortion) => void,
+    callback: (order?: ServiceOrder, orderRemoval?: OrderPortion) => void,
     cancelled$: Observable<void>,
   ) => {
     if (args.existing) {
       this.orderBook.pairIds.forEach((pair) => {
         const ownOrders = this.orderBook.getOwnOrders(pair);
         const peerOrders = this.orderBook.getPeersOrders(pair);
-        ownOrders.buyArray.forEach(order => callback(order));
-        peerOrders.buyArray.forEach(order => callback(order));
-        ownOrders.sellArray.forEach(order => callback(order));
-        peerOrders.sellArray.forEach(order => callback(order));
+        ownOrders.buyArray.forEach(order => callback(this.toServiceOrder(order, false)));
+        peerOrders.buyArray.forEach(order => callback(this.toServiceOrder(order, true)));
+        ownOrders.sellArray.forEach(order => callback(this.toServiceOrder(order, false)));
+        peerOrders.sellArray.forEach(order => callback(this.toServiceOrder(order, true)));
       });
     }
 
@@ -719,7 +719,7 @@ class Service extends EventEmitter {
     ).pipe(takeUntil(cancelled$)); // cleanup listeners when cancelled$ emits a value
 
     orderAdded$.subscribe({
-      next: callback,
+      next: order => callback(this.toServiceOrder(order, true)),
       error: this.logger.error,
     });