feat(cli): add price max precision checks for orders creation (#1385)

Date:      Tue Feb 4 19:49:35 2020 +0300
 Changes to be committed:
	modified:   lib/cli/placeorder.ts
	modified:   lib/cli/utils.ts
	modified:   lib/service/Service.ts
	modified:   npm-shrinkwrap.json
	modified:   package.json

Author: engwarrior

Diff for: lib/cli/placeorder.ts

@@ -2,11 +2,13 @@ import { Arguments, Argv } from 'yargs';
 import { Order, OrderSide, PlaceOrderEvent, PlaceOrderRequest, PlaceOrderResponse, SwapFailure, SwapSuccess } from '../proto/xudrpc_pb';
 import { callback, loadXudClient } from './command';
 import { coinsToSats, satsToCoinsStr } from './utils';
+import { checkDecimalPlaces } from '../utils/utils';
 
 export const placeOrderBuilder = (argv: Argv, side: OrderSide) => {
   const command = side === OrderSide.BUY ? 'buy' : 'sell';
   argv.option('quantity', {
     type: 'number',
+    describe: 'the quantity to trade',
   })
   .option('pair_id', {
     type: 'string',
@@ -62,6 +64,12 @@ export const placeOrderHandler = (argv: Arguments<any>, side: OrderSide) => {
     return;
   }
 
+  if (checkDecimalPlaces(numericPrice)) {
+    process.exitCode = 1;
+    console.error('price cannot have more than 12 decimal places');
+    return;
+  }
+
   if (argv.replace_order_id) {
     request.setReplaceOrderId(argv.replace_order_id);
   }

Diff for: lib/service/Service.ts

@@ -11,7 +11,7 @@ import { TradingLimits } from '../swaps/SwapClient';
 import Swaps from '../swaps/Swaps';
 import { ResolveRequest, SwapFailure, SwapSuccess } from '../swaps/types';
 import { parseUri, toUri, UriParts } from '../utils/uriUtils';
-import { sortOrders, toEip55Address } from '../utils/utils';
+import { checkDecimalPlaces, sortOrders, toEip55Address } from '../utils/utils';
 import commitHash from '../Version';
 import errors from './errors';
 
@@ -58,6 +58,9 @@ const argChecks = {
   POSITIVE_AMOUNT: ({ amount }: { amount: number }) => { if (amount <= 0) throw errors.INVALID_ARGUMENT('amount must be greater than 0'); },
   POSITIVE_QUANTITY: ({ quantity }: { quantity: number }) => { if (quantity <= 0) throw errors.INVALID_ARGUMENT('quantity must be greater than 0'); },
   PRICE_NON_NEGATIVE: ({ price }: { price: number }) => { if (price < 0) throw errors.INVALID_ARGUMENT('price cannot be negative'); },
+  PRICE_MAX_DECIMAL_PLACES: ({ price }: { price: number }) => {
+    if (checkDecimalPlaces(price)) throw errors.INVALID_ARGUMENT('price cannot have more than 12 decimal places');
+  },
   VALID_CURRENCY: ({ currency }: { currency: string }) => {
     if (currency.length < 2 || currency.length > 5 || !currency.match(/^[A-Z0-9]+$/)) {
       throw errors.INVALID_ARGUMENT('currency must consist of 2 to 5 upper case English letters or numbers');
@@ -447,6 +450,7 @@ class Service {
     const { pairId, price, quantity, orderId, side, replaceOrderId, immediateOrCancel } = args;
     argChecks.PRICE_NON_NEGATIVE(args);
     argChecks.POSITIVE_QUANTITY(args);
+    argChecks.PRICE_MAX_DECIMAL_PLACES(args);
     argChecks.HAS_PAIR_ID(args);
 
     if (replaceOrderId) {

Diff for: lib/utils/utils.ts

@@ -9,6 +9,8 @@ import { promisify } from 'util';
 import { Order, Pair } from '../orderbook/types';
 import p2pErrors from '../p2p/errors';
 
+const MAX_DECIMAL_PLACES = 12;
+
 /**
  * Gets the external IP of the node.
  */
@@ -105,6 +107,12 @@ export const groupBy = (arr: object[], keyGetter: (item: any) => string | number
   return ret;
 };
 
+/** Returns true if number has more than MAX_DECIMAL_PLACES, false otherwise. */
+export const checkDecimalPlaces = (digits: number) => {
+  const fixed = Number(digits.toFixed(MAX_DECIMAL_PLACES));
+  return fixed < digits;
+};
+
 /**
  * Get current time in unix time (milliseconds).
  */