feat(tests): upgrade connext simtests to 7.3.6 (#1833)

* feat(tests): upgrade connext simtests to 7.3.6

Author: Karl Ranna

Diff for: lib/connextclient/README.md

@@ -32,7 +32,7 @@ Create environment variables file and point to the Etheruem and Connext node
 
 ```bash
 CONNEXT_ETH_PROVIDER_URL="http://0.0.0.0:8545"
-CONNEXT_NODE_URL="http://0.0.0.0:8080"
+CONNEXT_NODE_URL="http://0.0.0.0:8888"
 ```
 
 Then run the REST API server

Diff for: test/simulation/connexttest/client.go

@@ -32,6 +32,7 @@ func (cfg Config) genEnvVars() []string {
 	args = append(args, fmt.Sprintf("CONNEXT_NODE_URL=%v", cfg.NodeURL))
 	args = append(args, fmt.Sprintf("PORT=%v", cfg.Port))
 	args = append(args, fmt.Sprintf("CONNEXT_STORE_DIR=%v", cfg.DataDir))
+	args = append(args, fmt.Sprintf("LEGACY_MODE=true"))
 
 	return args
 }

Diff for: test/simulation/connexttest/harness.go

@@ -16,7 +16,7 @@ var (
 	// 172.17.0.1 is the static IP equivalent of `host.docker.internal` for accessing
 	// the `localhost` of the host machine.
 	EthProviderURL = "http://172.17.0.1:8545"
-	NodeURL        = "http://172.17.0.1:8080"
+	NodeURL        = "http://172.17.0.1:8888"
 )
 
 type NetworkHarness struct {

Diff for: test/simulation/docker-build.sh

@@ -6,7 +6,7 @@ then
     pushd temp
     git clone https://github.com/ConnextProject/indra.git
     cd indra
-    git checkout indra-7.0.0
+    git checkout indra-7.3.6
     make
     popd
 fi

Diff for: test/simulation/docker-connext/Dockerfile

@@ -4,7 +4,9 @@ RUN apk add --no-cache git bash python3 make g++ python
 
 WORKDIR /app
 
+# This is a "hack" to automatically invalidate the cache in case there are new commits
+ADD https://api.github.com/repos/connext/rest-api-client/commits/master /dev/null
 RUN git clone https://github.com/connext/rest-api-client.git
 RUN cd rest-api-client && git pull
-RUN cd rest-api-client && git checkout 0ae160790faa6b5bc6b33114d726e1a3eb2fcfa3
+RUN cd rest-api-client && git checkout 9dafbfb914415f70a14123de9e295df175633c24
 RUN cd rest-api-client && npm install && npm run build

Diff for: test/simulation/tests-integration.go

@@ -462,13 +462,18 @@ func testOrderMatchingAndSwapConnext(net *xudtest.NetworkHarness, ht *harnessTes
 	// Open channel from Alice.
 	err = openETHChannel(ht.ctx, net.Alice, 40000, 0)
 	ht.assert.NoError(err)
+	// wait for 1 block for the deposit transaction to confirm
+	time.Sleep(15 * time.Second)
 
 	// Verify Alice ETH balance.
 	resBal, err = net.Alice.Client.GetBalance(ht.ctx, &xudrpc.GetBalanceRequest{Currency: "ETH"})
 	ht.assert.Equal(uint64(199997900), resBal.Balances["ETH"].TotalBalance)
 	ht.assert.Equal(resBal.Balances["ETH"].TotalBalance-40000, resBal.Balances["ETH"].WalletBalance)
 	ht.assert.Equal(uint64(40000), resBal.Balances["ETH"].ChannelBalance)
 
+	// wait for 1 block for node to collateralize ETH channel
+	time.Sleep(15 * time.Second)
+
 	// Place an order on Alice.
 	req := &xudrpc.PlaceOrderRequest{
 		OrderId:  "maker_order_id",