Skip to content

Commit 55c0c11

Browse files
committed
fix(rpc): correctly log errors for streaming calls
1 parent de2e6cb commit 55c0c11

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

Diff for: lib/grpc/GrpcServer.ts

+7-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,13 @@ class GrpcServer {
3232
if (!status) {
3333
logger.debug(`unknown status for call ${ctx.service.path}`);
3434
} else if (status.code !== 0) {
35-
logger.error(`call ${ctx.service.path} errored with code ${status.details.code}: ${status.details.message}`);
35+
if (typeof status.details === 'object') {
36+
logger.error(`call ${ctx.service.path} errored with code ${status.details.code}: ${status.details.message}`);
37+
} else if (typeof status.details === 'string') {
38+
logger.error(`call ${ctx.service.path} errored with code ${status.code}: ${status.details}`);
39+
} else {
40+
logger.error(`call ${ctx.service.path} errored with code ${status.code}`);
41+
}
3642
} else {
3743
logger.trace(`call ${ctx.service.path} succeeded`);
3844
}

0 commit comments

Comments
 (0)