feat(config): enable xud encryption by default

Author: sangaman

Diff for: lib/Config.ts

@@ -70,7 +70,7 @@ class Config {
   /** Whether matching will be disabled */
   public nomatching = false;
   /** Whether a password should not be used to encrypt the xud key and underlying wallets. */
-  public noencrypt = true; // TODO: enable encryption by default
+  public noencrypt = false;
   /**
    * Whether to disable sanity swaps that verify that the orders can possibly be swapped
    * before adding trading pairs as active.

Diff for: sample-xud.conf

@@ -26,6 +26,7 @@ describe('API Service', () => {
   before(async () => {
     const config = {
       initdb: false,
+      noencrypt: true,
       nosanityswaps: true,
       nobalancechecks: true,
       dbpath: ':memory:',

Diff for: test/integration/Service.spec.ts

@@ -13,6 +13,7 @@ describe('WebProxy', () => {
       xudir: getTempDir(true),
       dbpath: ':memory:',
       initdb: false,
+      noencrypt: true,
       webproxy: {
         port,
         disable: false,

Diff for: test/jest/WebProxy.spec.ts

@@ -12,6 +12,7 @@ export const createConfig = (instanceid: number, p2pPort: number, uniqueXudir =
   instanceid,
   network,
   initdb: false,
+  noencrypt: true,
   xudir: getTempDir(uniqueXudir),
   dbpath: ':memory:',
   loglevel: 'error',

Diff for: test/p2p/sanity.spec.ts

@@ -62,6 +62,7 @@ func (cfg nodeConfig) genArgs() []string {
 	args = append(args, "--initdb=false")
 	args = append(args, "--regtest")
 	args = append(args, "--loglevel=trace")
+	args = append(args, "--noencrypt")
 
 	if cfg.NoBalanceChecks {
 		args = append(args, "--nobalancechecks=true")