Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadTheDocs: enable automatic apidoc run/generation #33

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

SteVwonder
Copy link
Contributor

@SteVwonder SteVwonder commented May 18, 2021

Problem: when the documentation is built by ReadTheDocs with Sphinx, they (RTD) do not run autodoc first, resulting in a mostly empty doc site.

Solution: follow the workaround prescribed in readthedocs/readthedocs.org#1139 and add code to the conf.py to run autodoc as part of the normal sphinx build process. Also simplify the Makefile based on this new implicit build.

Closes #32

Problem: when the documentation is built by ReadTheDocs with Sphinx,
they (RTD) do not run autodoc first, resulting in a mostly empty doc
site.

Solution: follow the workaround prescribed in
readthedocs/readthedocs.org#1139 and add code
to the conf.py to run autodoc as part of the normal sphinx build process
Problem: Sphinx now automatically runs the apidoc as part of the normal
build process, making the explicit running of it via make redundant

Solution: simplify the makefile a bit and just run the normal
sphinx-build process, letting it handle apidoc generation
@SteVwonder SteVwonder marked this pull request as ready for review May 18, 2021 19:02
@SteVwonder SteVwonder closed this May 18, 2021
@SteVwonder SteVwonder reopened this May 18, 2021
@SteVwonder SteVwonder closed this May 18, 2021
@SteVwonder SteVwonder reopened this May 18, 2021
Copy link
Collaborator

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mturilli mturilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SteVwonder SteVwonder merged commit 7d378ff into ExaWorks:main Jun 4, 2021
@SteVwonder SteVwonder deleted the rtd-apidoc branch June 4, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: RTD not generating the complete autodocs
3 participants