Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Percentage missing from Lab and Lch parser #85

Closed
rozaxe opened this issue Jun 26, 2020 · 2 comments
Closed

Percentage missing from Lab and Lch parser #85

rozaxe opened this issue Jun 26, 2020 · 2 comments

Comments

@rozaxe
Copy link
Contributor

rozaxe commented Jun 26, 2020

As the specification states, lab and lch should accept a percentage as first argument (source).

As of today, lch(50% 50 50) will result in undefined when parsing it.

(I'm writing a Pull Request to handle percentage number)

And thanks for this great library ! Really usefull.
@danburzo
Copy link
Collaborator

Ah, good catch @rozaxe! It seems the spec has changed since the last time I read it 😅

@danburzo
Copy link
Collaborator

Fixed by @rozaxe in #86

@danburzo danburzo mentioned this issue Jun 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danburzo @rozaxe