Skip to content

Commit 7d19c83

Browse files
authored
fix: Add missing source command in Makefile install-docs-deps target (#5060)
## Changes Made Fixed missing `source` command in the `install-docs-deps` target that was causing "Permission denied" errors when running `make docs`. ## Problem The `install-docs-deps` target was trying to execute the activate script directly instead of sourcing it: ```makefile $(VENV_BIN)/activate && uv sync --all-extras --all-groups ``` This resulted in permission denied errors because the shell was attempting to execute the script rather than source it into the current environment. ## Solution Added the missing `source` command to be consistent with other targets in the Makefile: ```makefile source $(VENV_BIN)/activate && uv sync --all-extras --all-groups source $(VENV_BIN)/activate && uv pip install -e docs/plugins/nav_hide_children ``` This change makes the `install-docs-deps` target consistent with other targets like `hooks`, `check-format`, `lint`, etc. that correctly use `source $(VENV_BIN)/activate`.
1 parent 6c11a9a commit 7d19c83

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ install-docs-deps:
8989
curl -fsSL https://bun.sh/install | bash; \
9090
export PATH="$$HOME/.bun/bin:$$PATH"; \
9191
fi
92-
$(VENV_BIN)/activate && uv sync --all-extras --all-groups
93-
$(VENV_BIN)/activate && uv pip install -e docs/plugins/nav_hide_children
92+
source $(VENV_BIN)/activate && uv sync --all-extras --all-groups
93+
source $(VENV_BIN)/activate && uv pip install -e docs/plugins/nav_hide_children
9494

9595
.PHONY: docs
9696
docs: .venv install-docs-deps ## Build Daft documentation

0 commit comments

Comments
 (0)