Don't attempt reconnect unless status code is 200

EventSource · Apr 17, 2017 · af84476 · af84476
1 parent 33aec48
commit af84476
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/eventsource.js b/lib/eventsource.js
@@ -105,8 +105,7 @@ function EventSource(url, eventSourceInitDict) {
 
       if (res.statusCode !== 200) {
         _emit('error', new Event('error', {status: res.statusCode}));
-        if (res.statusCode == 204) return self.close();
-        return
+        return self.close();
       }
 
       readyState = EventSource.OPEN;

diff --git a/test/eventsource_test.js b/test/eventsource_test.js
@@ -600,7 +600,7 @@ describe('Reconnection', function () {
     });
   });
 
-  it('is not attempted when server responds with HTTP 204', function (done) {
+  it('is not attempted when server responds with non-200', function (done) {
     createServer(function (err, server) {
       if(err) return done(err);