backend-8080.c

/*
 *	Things to improve
 *	- Use the BC register either via a register hint in the compiler or by looking for
 *	  a non pointer arg candidate (especially on 8080 where the loads are expensive)
 *	- Improve initialized variable generation in stack frame creation
 *	- Avoid the two xchg calls on a void function cleanup (see gen_cleanup)
 *	- Do we want a single "LBREF or NREF name print" fuinction
 *	- Optimize xor 0xff with cpl ?
 *	- Inline load and store of long to static/global/label (certainly for -O2)
 *	- See if we can think down support routines that use the retaddr patching (ideally
 *	  remove them, if not fix Fuzix task switch to save/restore it)
 */
#include <stdio.h>
#include <stdint.h>
#include <stdlib.h>
#include <string.h>
#include <stdarg.h>
#include "compiler.h"
#include "backend.h"

#define BYTE(x)		(((unsigned)(x)) & 0xFF)
#define WORD(x)		(((unsigned)(x)) & 0xFFFF)

#define ARGBASE	2	/* Bytes between arguments and locals if no reg saves */

#define LWDIRECT 24	/* Number of __ldword1 __ldword2 etc forms for fastest access */

/*
 *	State for the current function
 */
static unsigned frame_len;	/* Number of bytes of stack frame */
static unsigned sp;		/* Stack pointer offset tracking */
static unsigned argbase;	/* Argument offset in current function */
static unsigned unreachable;	/* Code following an unconditional jump */
static unsigned func_cleanup;	/* Zero if we can just ret out */
static unsigned label;		/* Used to hand out local labels in the form X%u */

/*
 *	Output side logic. For now dumb but route everything here so
 *	we can do more useful stuff later
 */

#define OP_XCHG		1
#define OP_PUSH		2
#define OP_LXI		3
#define OP_DAD		4
#define OP_SPHL		5
#define OP_INX		6
#define OP_DCX		7
#define OP_RET		8
#define OP_POP		9
#define OP_MOV		10
#define OP_MVI		11
#define OP_LHLD		12
#define OP_SHLD		13
#define OP_LDA		14
#define OP_STA		15
#define OP_ARHL		16
#define OP_DSUB		17
#define OP_LDAX		18
#define OP_STAX		19
#define OP_XTHL		20
#define OP_LHLX		21
#define OP_SHLX		22
#define OP_LDSI		23
#define OP_LDHI		24
#define OP_CALL		25
#define OP_JUMP		26
#define OP_DATA		27
#define OP_COMMENT	28
#define OP_LABEL	29
#define OP_INC		30
#define OP_DEC		31
#define OP_ADD		32
#define OP_ANA		33
#define OP_ORA		34

#define	R_A		1
#define R_PSW		1		/* Unless we start CC tracking */
#define R_B		2
#define R_C		4
#define R_BC		(R_B|R_C)
#define R_D		8
#define R_E		16
#define R_DE		(R_D|R_E)
#define R_H		32
#define R_L		64
#define R_HL		(R_H|R_L)
#define R_M		128
#define R_SP		256
#define	R_MEM		512
#define R_KEEP		1024		/* Not to be removed */
#define R_ALL		(R_PSW|R_BC|R_DE|R_HL|R_SP|R_MEM)

static void opcode(unsigned code, unsigned rs, unsigned rd, const char *p, ...)
{
	va_list v;
	va_start(v, p);
	if (code != OP_LABEL && code != OP_COMMENT)
		putchar('\t');
	vprintf(p, v);
	putchar('\n');
	va_end(v);
}

static void set_segment(unsigned seg)
{
	/* Track segments for output */
}

/* Finish and write any data */
static void opcode_flush(void)
{
}

/*
 *	Object sizes
 */

static unsigned get_size(unsigned t)
{
	if (PTR(t))
		return 2;
	if (t == CSHORT || t == USHORT)
		return 2;
	if (t == CCHAR || t == UCHAR)
		return 1;
	if (t == CLONG || t == ULONG || t == FLOAT)
		return 4;
	if (t == CLONGLONG || t == ULONGLONG || t == DOUBLE)
		return 8;
	if (t == VOID)
		return 0;
	fprintf(stderr, "type %x\n", t);
	error("gs");
	return 0;
}

static unsigned get_stack_size(unsigned t)
{
	unsigned n = get_size(t);
	if (n == 1)
		return 2;
	return n;
}

#define T_NREF		(T_USER)		/* Load of C global/static */
#define T_CALLNAME	(T_USER+1)		/* Function call by name */
#define T_NSTORE	(T_USER+2)		/* Store to a C global/static */
#define T_LREF		(T_USER+3)		/* Ditto for local */
#define T_LSTORE	(T_USER+4)
#define T_LBREF		(T_USER+5)		/* Ditto for labelled strings or local static */
#define T_LBSTORE	(T_USER+6)
#define T_RREF		(T_USER+7)
#define T_RSTORE	(T_USER+8)
#define T_RDEREF	(T_USER+9)		/* *regptr */
#define T_REQ		(T_USER+10)		/* *regptr */

static void squash_node(struct node *n, struct node *o)
{
	n->value = o->value;
	n->val2 = o->val2;
	n->snum = o->snum;
	free_node(o);
}

static void squash_left(struct node *n, unsigned op)
{
	struct node *l = n->left;
	n->op = op;
	squash_node(n, l);
	n->left = NULL;
}

static void squash_right(struct node *n, unsigned op)
{
	struct node *r = n->right;
	n->op = op;
	squash_node(n, r);
	n->right = NULL;
}

/*
 *	Heuristic for guessing what to put on the right. This is very
 *	processor dependent. For 8080 we are quite limited especially
 *	with locals. In theory we could extend some things to 8bit
 *	locals on 8085 (ldsi, ldax d, mov e,a)
 */

static unsigned is_simple(struct node *n)
{
	unsigned op = n->op;

	/* Multi-word objects are never simple */
	if (!PTR(n->type) && (n->type & ~UNSIGNED) > CSHORT)
		return 0;

	/* We can load these directly into a register */
	if (op == T_CONSTANT || op == T_LABEL || op == T_NAME)
		return 10;
	/* We can load this directly into a register but may need xchg pairs */
	if (op == T_NREF || op == T_LBREF)
		return 1;
	return 0;
}

/* Chance to rewrite the tree from the top rather than none by node
   upwards. We will use this for 8bit ops at some point and for cconly
   propagation */
struct node *gen_rewrite(struct node *n)
{
	return n;
}

/*
 *	Our chance to do tree rewriting. We don't do much for the 8080
 *	at this point, but we do rewrite name references and function calls
 *	to make them easier to process.
 */
struct node *gen_rewrite_node(struct node *n)
{
	struct node *l = n->left;
	struct node *r = n->right;
	unsigned op = n->op;
	unsigned nt = n->type;

	/* TODO
		- rewrite some reg ops
	*/

	/* *regptr. Only works for bytes, so if the size is wrong (e.g. the pointer
	   was cast) then force it into HL and the usual path */
	if (op == T_DEREF && r->op == T_RREF && (nt == CCHAR || nt == UCHAR)) {
		n->op = T_RDEREF;
		n->right = NULL;
		n->val2 = 0;
		n->value = r->value;
		free_node(r);
		return n;
	}
	/* *regptr = */
	if (op == T_EQ && l->op == T_RREF && (nt == CCHAR || nt == UCHAR)) {
		n->op = T_REQ;
		n->val2 = 0;
		n->value = l->value;
		n->left = NULL;
		free_node(l);
		return n;
	}
	/* Rewrite references into a load operation */
	if (nt == CCHAR || nt == UCHAR || nt == CSHORT || nt == USHORT || PTR(nt)) {
		if (op == T_DEREF) {
			if (r->op == T_LOCAL || r->op == T_ARGUMENT) {
				if (r->op == T_ARGUMENT)
					r->value += argbase + frame_len;
				squash_right(n, T_LREF);
				return n;
			}
			if (r->op == T_REG) {
				squash_right(n, T_RREF);
				return n;
			}
			if (r->op == T_NAME) {
				squash_right(n, T_NREF);
				return n;
			}
			if (r->op == T_LABEL) {
				squash_right(n, T_LBREF);
				return n;
			}
		}
		if (op == T_EQ) {
			if (l->op == T_NAME) {
				squash_left(n, T_NSTORE);
				return n;
			}
			if (l->op == T_LABEL) {
				squash_left(n, T_LBSTORE);
				return n;
			}
			if (l->op == T_LOCAL || l->op == T_ARGUMENT) {
				if (l->op == T_ARGUMENT)
					l->value += argbase + frame_len;
				squash_left(n, T_LSTORE);
				return n;
			}
			if (l->op == T_REG) {
				squash_left(n, T_RSTORE);
				return n;
			}
		}
	}
	/* Eliminate casts for sign, pointer conversion or same */
	if (op == T_CAST) {
		if (nt == r->type || (nt ^ r->type) == UNSIGNED ||
		 (PTR(nt) && PTR(r->type))) {
			free_node(n);
			return r;
		}
	}
	/* Rewrite function call of a name into a new node so we can
	   turn it easily into call xyz */
	if (op == T_FUNCCALL && r->op == T_NAME && PTR(r->type) == 1) {
		n->op = T_CALLNAME;
		n->snum = r->snum;
		n->value = r->value;
		free_node(r);
		n->right = NULL;
	}
	/* Commutive operations. We can swap the sides over on these */
	if (op == T_AND || op == T_OR || op == T_HAT || op == T_STAR || op == T_PLUS) {
/*		printf(";left %d right %d\n", is_simple(n->left), is_simple(n->right)); */
		if (is_simple(n->left) > is_simple(n->right)) {
			n->right = l;
			n->left = r;
		}
	}
	return n;
}

/* Export the C symbol */
void gen_export(const char *name)
{
	printf("	.export _%s\n", name);
}

void gen_segment(unsigned segment)
{
	set_segment(segment);
	switch(segment) {
	case A_CODE:
		printf("\t.%s\n", codeseg);
		break;
	case A_DATA:
		printf("\t.data\n");
		break;
	case A_BSS:
		printf("\t.bss\n");
		break;
	case A_LITERAL:
		printf("\t.literal\n");
		break;
	default:
		error("gseg");
	}
}

/* Generate the function prologue - may want to defer this until
   gen_frame for the most part */
void gen_prologue(const char *name)
{
	opcode(OP_LABEL, 0, R_KEEP, "_%s:\n", name);
	unreachable = 0;
}

/* Generate the stack frame */
/* TODO: defer this to statements so we can ld/push initializers */
void gen_frame(unsigned size, unsigned aframe)
{
	frame_len = size;
	sp = 0;

	if (size || func_flags & F_REG(1))
		func_cleanup = 1;
	else
		func_cleanup = 0;

	argbase = ARGBASE;
	if (func_flags & F_REG(1)) {
		opcode(OP_PUSH, R_BC|R_SP, R_SP, "push b");
		argbase += 2;
	}
	if (size > 10) {
		opcode(OP_LXI, 0, R_HL, "lxi h,%u", (-size) & 0xFFFF);
		opcode(OP_DAD, R_SP|R_HL, R_HL, "dad sp");
		opcode(OP_SPHL, R_HL, R_SP, "sphl");
		return;
	}
	if (size & 1) {
		opcode(OP_DCX, R_SP, R_SP, "dcx sp");
		size--;
	}
	while(size) {
		opcode(OP_PUSH, R_HL|R_SP, R_SP, "push h");
		size -= 2;
	}
}

void gen_epilogue(unsigned size, unsigned argsize)
{
	unsigned x = func_flags & F_VOIDRET;
	if (sp != 0)
		error("sp");

	if (unreachable)
		return;

	/* Return in HL, does need care on stack. TOOD: flag void functions
	   where we can burn the return */
	sp -= size;
	if (cpu == 8085 && size <= 255 && size > 4) {
		opcode(OP_LDSI, R_SP, R_DE, "ldsi %u", size);
		opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
		opcode(OP_SPHL, R_HL, R_SP, "sphl");
		opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
	} else if (size > 10) {
		if (!x)
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
		opcode(OP_LXI, 0, R_HL, "lxi h,0x%x", (uint16_t)size);
		opcode(OP_DAD, R_SP|R_HL, R_HL, "dad sp");
		opcode(OP_SPHL, R_HL, R_SP, "sphl");
		if (!x)
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
	} else {
		if (size & 1) {
			opcode(OP_INX, R_SP, R_SP, "inx sp");
			size--;
		}
		while (size) {
			opcode(OP_POP, R_SP, R_SP|R_DE, "pop d");
			size -= 2;
		}
	}
	if (func_flags & F_REG(1))
		opcode(OP_POP, R_SP, R_SP|R_BC, "pop b");
	/* TODO: make this a little "ret" func as it has several users */
	if (x)
		opcode(OP_RET, 0, 0, "ret");
	else
		opcode(OP_RET, R_HL, 0, "ret");
}

void gen_label(const char *tail, unsigned n)
{
	unreachable = 0;
	/* A branch label means the state is unknown so force any
	   existing state and don't assume anything */
	opcode(OP_LABEL, R_ALL, R_ALL, "L%u%s:", n, tail);
}

/* A return statement. We can sometimes shortcut this if we have
   no cleanup to do */
unsigned gen_exit(const char *tail, unsigned n)
{
	if (unreachable)
		return 1;
	if (func_cleanup) {
		gen_jump(tail, n);
		unreachable = 1;
		return 0;
	} else {
		/* FIXME: R_HL depends on func != void */
		opcode(OP_RET, R_HL, 0, "ret");
		unreachable = 1;
		return 1;
	}
}

void gen_jump(const char *tail, unsigned n)
{
	/* Force anything deferred to complete before the jump */
	opcode(OP_JUMP, R_ALL, 0, "jmp L%u%s", n, tail);
	unreachable = 1;
}

void gen_jfalse(const char *tail, unsigned n)
{
	opcode(OP_JUMP, R_ALL, 0, "jz L%u%s", n, tail);
}

void gen_jtrue(const char *tail, unsigned n)
{
	opcode(OP_JUMP, R_ALL, 0, "jnz L%u%s", n, tail);
}

static void gen_cleanup(unsigned v)
{
	/* CLEANUP is special and needs to be handled directly */
	sp -= v;
	if (v > 10) {
		/* This is more expensive, but we don't often pass that many
		   arguments so it seems a win to stay in HL */
		unsigned x = func_flags & F_VOIDRET;
		if (!x)
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
		opcode(OP_LXI, 0, R_HL, "lxi h,%u", v);
		opcode(OP_DAD, R_SP|R_HL, R_HL, "dad sp");
		opcode(OP_SPHL, R_HL, R_SP, "sphl");
		if (!x)
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
	} else {
		while(v >= 2) {
			opcode(OP_POP, R_SP, R_DE|R_SP, "pop d");
			v -= 2;
		}
		if (v)
			opcode(OP_INX, R_SP, R_SP, "inx sp");
	}
}

/*
 *	Helper handlers. We use a tight format for integers but C
 *	style for float as we'll have C coded float support if any
 */

/* True if the helper is to be called C style */
static unsigned c_style(struct node *np)
{
	register struct node *n = np;
	/* Assignment is done asm style */
	if (n->op == T_EQ)
		return 0;
	/* Float ops otherwise are C style */
	if (n->type == FLOAT)
		return 1;
	n = n->right;
	if (n && n->type == FLOAT)
		return 1;
	return 0;
}

void gen_helpcall(struct node *n)
{
	/* Check both N and right because we handle casts to/from float in
	   C call format */
	if (c_style(n))
		gen_push(n->right);
	printf("\tcall __");
}

void gen_helptail(struct node *n)
{
}

void gen_helpclean(struct node *n)
{
	unsigned s;

	if (c_style(n)) {
		s = 0;
		if (n->left) {
			s += get_size(n->left->type);
			/* gen_node already accounted for removing this thinking
			   the helper did the work, adjust it back as we didn't */
			sp += s;
		}
		s += get_size(n->right->type);
		gen_cleanup(s);
		/* C style ops that are ISBOOL didn't set the bool flags */
		if (n->flags & ISBOOL)
			printf("\txra a\n\tcmp l\n");
	}
}

void gen_switch(unsigned n, unsigned type)
{
	opcode(OP_LXI, 0, R_DE, "lxi d,Sw%u", n);
	/* Nothing is preserved over a switch */
	printf("\tjmp __switch");
	helper_type(type, 0);
	putchar('\n');
}

void gen_switchdata(unsigned n, unsigned size)
{
	opcode(OP_LABEL, 0, 0, "Sw%u:", n);
	opcode(OP_DATA, 0, 0, ".word %u", size);
}

void gen_case_label(unsigned tag, unsigned entry)
{
	unreachable = 0;
	opcode(OP_LABEL, 0, 0, "Sw%u_%u:", tag, entry);
}

void gen_case_data(unsigned tag, unsigned entry)
{
	opcode(OP_LABEL, 0, 0, ".word Sw%u_%u", tag, entry);
}

void gen_data_label(const char *name, unsigned align)
{
	opcode(OP_LABEL, 0, 0, "_%s:", name);
}

void gen_space(unsigned value)
{
	opcode(OP_DATA, 0, 0, ".ds %u", value);
}

void gen_text_data(struct node *n)
{
	opcode(OP_DATA, 0, 0, ".word T%u", n->val2);
}

/* The label for a literal (currently only strings) */
void gen_literal(unsigned n)
{
	if (n)
		opcode(OP_LABEL, 0, 0, "T%u:", n);
}

void gen_name(struct node *n)
{
	opcode(OP_DATA, 0, 0, ".word _%s+%u", namestr(n->snum), WORD(n->value));
}

void gen_value(unsigned type, unsigned long value)
{
	unsigned w = WORD(value);
	if (PTR(type)) {
		opcode(OP_DATA, 0, 0, ".word %u", w);
		return;
	}
	switch (type) {
	case CCHAR:
	case UCHAR:
		opcode(OP_DATA, 0, 0, ".byte %u", BYTE(w));
		break;
	case CSHORT:
	case USHORT:
		opcode(OP_DATA, 0, 0, ".word %u", w);
		break;
	case CLONG:
	case ULONG:
	case FLOAT:
		/* We are little endian */
		opcode(OP_DATA, 0, 0, ".word %u\n", w);
		opcode(OP_DATA, 0, 0, ".word %u\n", (unsigned) ((value >> 16) & 0xFFFF));
		break;
	default:
		error("unsuported type");
	}
}

void gen_start(void)
{
	printf("\t.setcpu %u\n", cpu);
}

void gen_end(void)
{
	opcode_flush();
}

void gen_tree(struct node *n)
{
	codegen_lr(n);
	opcode(OP_COMMENT, 0, 0, ";");
/*	printf(";SP=%d\n", sp); */
}

/*
 *	Get a local variable into HL or DE.
 *
 *	Loading into HL may not fail (return 0 is a compiler abort) but may
 *	trash DE as well. Loading into DE may fail and is not permitted
 *	to trash HL.
 */
unsigned gen_lref(unsigned v, unsigned size, unsigned to_de)
{
	const char *name;
	/* Trivial case: if the variable is top of stack then just pop and
	   push it back */
	if (v == 0 && size == 2) {
		if (to_de) {
			opcode(OP_POP, R_SP, R_SP|R_DE, "pop d");
			opcode(OP_PUSH, R_SP|R_DE, R_SP, "push d");
		} else {
			opcode(OP_POP, R_SP, R_SP|R_HL, "pop h");
			opcode(OP_PUSH, R_SP|R_HL, R_SP, "push h");
		}
		return 1;
	}
	/* The 8085 has LDSI and LHLX so we can fast access anything up to
	   255 bytes from SP. However we end up trashing DE in doing so. For
	   now don't use this for DE loads, look at saving stuff later TODO */
	if (cpu == 8085 && v <= 255 && !to_de) {
		opcode(OP_LDSI, R_SP, R_DE, "ldsi %u", v);
		if (size == 2)
			opcode(OP_LHLX, R_DE|R_M, R_HL, "lhlx");
		else {
			opcode(OP_LDAX, R_DE|R_M, R_A, "ldax d");
			opcode(OP_MOV, R_A, R_L, "mov l,a");
		}
		return 1;
	}
	/*
	 *	We can get at the second variable fastest by popping two
	 *	things but must destroy DE so can only use this for HL
	 */
	if (!to_de && v == 2 && size == 2) {
		opcode(OP_POP, R_SP, R_DE|R_SP, "pop d");
		opcode(OP_POP, R_SP, R_HL|R_SP, "pop h");
		opcode(OP_PUSH, R_SP, R_DE|R_SP, "push h");
		opcode(OP_PUSH, R_SP, R_HL|R_SP, "push d");
		return 1;
	}
	/* Byte load is shorter inline for most cases */
	if (size == 1 && (!optsize || v >= LWDIRECT || to_de)) {
		if (to_de)
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
		opcode(OP_LXI, 0, R_HL, "lxi h,%u", v);
		opcode(OP_DAD, R_SP|R_HL, R_HL, "dad sp");
		opcode(OP_MOV, R_HL|R_M, R_L, "mov l,m");
		if (to_de)
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
		return 1;
	}
	/* Longer reach for 8085 is via addition games, but only for HL
	   as lhlx requires we use DE and HL */
	if (cpu == 8085 && size == 2 && !to_de) {
		opcode(OP_LXI, 0, R_HL, "lxi h,%u", WORD(v));
		opcode(OP_DAD, R_SP|R_HL, R_HL, "dad sp");
		opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
		opcode(OP_LHLX, R_DE|R_M, R_HL, "lhlx");
		return 1;
	}
	/* Word load is long winded on 8080 but if the user asked for it */
	/* This also gets used for 8085 as a fallback for the DE case */
	if (size == 2 && opt > 2) {
		if (to_de)
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
		opcode(OP_DAD, R_SP|R_HL, R_HL, "dad sp");
		opcode(OP_MOV, R_M|R_HL, R_A, "mov a,m");
		opcode(OP_INX, R_HL, R_HL, "inx h");
		opcode(OP_MOV, R_M|R_HL, R_L, "mov h,m");
		opcode(OP_MOV, R_A, R_L, " mov l,a");
		if (to_de)
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
		return 1;
	}
	/* The 8080 has a bunch of helpers as we just xchg around them for
	   the DE case. The 8085 has only a word helper and for both the
	   word helper has it use HL and DE. Those cases go via stack */
	if (to_de && (cpu == 8085 || v >= 253))
		return 0;	/* Go via stack */

	/* Via helper magic for compactness on 8080 */
	if (size == 1)
		name = "ldbyte";
	else if (size == 2)
		name = "ldword";
	else
		return 0;	/* Can't happen currently but trap it */
	/* We do a call so the stack offset is two bigger */
	if (to_de)
		opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");

	if (v < LWDIRECT)
		printf("\tcall __%s%u\n", name, v + 2);
	else if (v < 253)
		printf("\tcall __%s\n\t.byte %u\n", name, v + 2);
	else
		printf("\tcall __%sw\n\t.word %u\n", name, v + 2);

	if (to_de)
		opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");

	return 1;
}

/*
 *	Try and generate shorter code for stuff we can directly access
 */

/*
 *	Return 1 if the node can be turned into direct access. The VOID check
 *	is a special case we need to handle stack clean up of void functions.
 */
static unsigned access_direct(struct node *n)
{
	unsigned op = n->op;

	/* The 8080 we can reliably access stuff within 253 bytes of the
	   current stack pointer. 8085 we don't have the short helpers as they
	   are not worth it for this case, but we can do it via the 4 byte one */
	if (op == T_LREF && n->value + sp < 253)
		return 1;
	/* We can direct access integer or smaller types that are constants
	   global/static or string labels */
	/* TODO group the user ones together for a range check ? */
	if (op != T_CONSTANT && op != T_NAME && op != T_LABEL &&
		 op != T_NREF && op != T_LBREF && op != T_RREF)
		 return 0;
	if (!PTR(n->type) && (n->type & ~UNSIGNED) > CSHORT)
		return 0;
	return 1;
}

static unsigned access_direct_b(struct node *n)
{
	/* We can't access as much via B directly because we've got no easy xchg with b */
	/* TODO: if we want BC we need to know if BC currently holds the reg var */
	if (n->op != T_CONSTANT && n->op != T_NAME && n->op != T_LABEL && n->op != T_REG)
		return 0;
	if (!PTR(n->type) && (n->type & ~UNSIGNED) > CSHORT)
		return 0;
	return 1;
}

/*
 *	Get something that passed the access_direct check into de. Could
 *	we merge this with the similar hl one in the main table ?
 */

static unsigned load_r_with(const char r, struct node *n, unsigned mask)
{
	unsigned v = WORD(n->value);
	const char *name;

	switch(n->op) {
	case T_NAME:
		opcode(OP_LXI, 0, mask, "lxi %c,_%s+%u", r, namestr(n->snum), v);
		return 1;
	case T_LABEL:
		opcode(OP_LXI, 0, mask, "lxi %c,T%u+%u", r, n->val2, v);
		return 1;
	case T_CONSTANT:
		/* We know this is not a long from the checks above */
		opcode(OP_LXI, 0, mask, "lxi %c,%u", r, v);
		return 1;
	case T_NREF:
		name = namestr(n->snum);
		if (r == 'b')
			return 0;
		else if (r == 'h') {
			opcode(OP_LHLD, R_MEM, R_HL, "lhld _%s+%u", name, v);
			return 1;
		} else if (r == 'd') {
			/* We know it is int or pointer */
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			opcode(OP_LHLD, R_MEM, R_HL, "lhld _%s+%u\n", name, v);
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			return 1;
		}
		break;
	/* TODO: fold together cleanly with NREF */
	case T_LBREF:
		if (r == 'b')
			return 0;
		else if (r == 'h') {
			opcode(OP_LHLD, R_MEM, R_HL, "lhld T%u+%u", n->val2, v);
			return 1;
		} else if (r == 'd') {
			/* We know it is int or pointer */
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			opcode(OP_LHLD, R_MEM, R_HL, "lhld T%u+%u", n->val2, v);
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			return 1;
		}
		break;
	case T_RREF:
		if (r == 'd') {
			opcode(OP_MOV, R_B, R_D, "mov d,b");
			opcode(OP_MOV, R_C, R_E, "mov e,c\n");
		} else if (r == 'h') {
			opcode(OP_MOV, R_B, R_H, "mov h,b");
			opcode(OP_MOV, R_C, R_L, "mov l,c\n");
		}
		/* Assumes that BC isn't corrupted yet so is already the right value. Use
		   this quirk with care (eg T_MINUS) */
		return 1;
	default:
		return 0;
	}
	return 1;
}

static unsigned load_bc_with(struct node *n)
{
	/* No lref direct to BC option for now */
	return load_r_with('b', n, R_BC);
}

static unsigned load_de_with(struct node *n)
{
	if (n->op == T_LREF)
		return gen_lref(n->value + sp, 2, 1);
	return load_r_with('d', n, R_DE);
}

static unsigned load_hl_with(struct node *n)
{
	if (n->op == T_LREF)
		return gen_lref(n->value + sp, 2, 0);
	return load_r_with('h', n, R_HL);
}

static unsigned load_a_with(struct node *n)
{
	switch(n->op) {
	case T_CONSTANT:
		/* We know this is not a long from the checks above */
		opcode(OP_MVI, 0, R_A, "mvi a,%u", BYTE(n->value));
		break;
	case T_NREF:
		opcode(OP_LDA, R_MEM, R_A, "lda _%s+%u", namestr(n->snum), WORD(n->value));
		break;
	case T_LBREF:
		opcode(OP_LDA, R_MEM, R_A, "lda T%u+%u", n->val2, WORD(n->value));
		break;
	case T_RREF:
		opcode(OP_MOV, R_C, R_A, "mov a,c");
		break;
	case T_LREF:
		/* We don't want to trash HL as we may be doing an HL:A op */
		opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
		opcode(OP_LXI, 0, R_HL, "lxi h,%u", WORD(n->value));
		opcode(OP_DAD, R_HL|R_SP, R_HL, "dad sp");
		opcode(OP_MOV, R_HL|R_M, R_A, "mov a,m");
		opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
		break;
	default:
		return 0;
	}
	return 1;
}

/* TODO: needs a format change */
static void repeated_op(const char *o, unsigned n)
{
	while(n--)
		printf("\t%s\n", o);
}

static void loadhl(struct node *n, unsigned s)
{
	if (n && (n->flags & NORETURN))
		return;
	opcode(OP_MOV, R_C, R_L, "mov l,c");
	if (s == 2)
		opcode(OP_MOV, R_B, R_H, "mov h,b");
}

static void loadbc(unsigned s)
{
	opcode(OP_MOV, R_L, R_C, "mov c,l");
	if (s == 2)
		opcode(OP_MOV, R_H, R_B, "mov b,h");
}

/* We use "DE" as a name but A as register for 8bit ops... probably ought to rework one day */
static unsigned gen_deop(const char *op, struct node *n, struct node *r, unsigned sign)
{
	unsigned s = get_size(n->type);
	if (s > 2)
		return 0;
	if (s == 2) {
		if (load_de_with(r) == 0)
			return 0;
	} else {
		if (load_a_with(r) == 0)
			return 0;
	}
	if (sign)
		helper_s(n, op);
	else
		helper(n, op);
	return 1;
}

/* TODO: someone needs to own eliminating no side effect impossible
   or true expressions like unsigned < 0 */
static unsigned gen_compc(const char *op, struct node *n, struct node *r, unsigned sign)
{
	if (r->op == T_CONSTANT && r->value == 0 && r->type != FLOAT) {
		char buf[10];
		strcpy(buf, op);
		strcat(buf, "0");
		if (sign)
			helper_s(n, buf);
		else
			helper(n, buf);
		n->flags |= ISBOOL;
		return 1;
	}
	if (gen_deop(op, n, r, sign)) {
		n->flags |= ISBOOL;
		return 1;
	}
	return 0;
}

static int count_mul_cost(unsigned n)
{
	int cost = 0;
	if ((n & 0xFF) == 0) {
		n >>= 8;
		cost += 3;		/* mov mvi */
	}
	while(n > 1) {
		if (n & 1)
			cost += 3;	/* push pop dad d */
		n >>= 1;
		cost++;			/* dad h */
	}
	return cost;
}

/* Write the multiply for any value > 0 */
static void write_mul(unsigned n)
{
	unsigned pops = 0;
	if ((n & 0xFF) == 0) {
		opcode(OP_MOV, R_L, R_H, "mov h,l");
		opcode(OP_MVI, 0, R_L, "mvi l,0");
		n >>= 8;
	}
	while(n > 1) {
		if (n & 1) {
			pops++;
			opcode(OP_PUSH, R_SP|R_HL, R_SP, "push h");
		}
		opcode(OP_DAD, R_HL, R_HL, "dad h");
		n >>= 1;
	}
	while(pops--) {
		opcode(OP_POP, R_SP, R_SP|R_DE, "pop d");
		opcode(OP_DAD, R_DE|R_HL, R_HL, "dad d");
	}
}

static unsigned can_fast_mul(unsigned s, unsigned n)
{
	/* Pulled out of my hat 8) */
	unsigned cost = 15 + 3 * opt;
	/* The base cost of the helper is 6 lxi de, n; call, but this may be too aggressive
	   given the cost of mulde TODO */
	if (optsize)
		cost = 10;
	if (s > 2)
		return 0;
	if (n == 0 || count_mul_cost(n) <= cost)
		return 1;
	return 0;
}

static void gen_fast_mul(unsigned s, unsigned n)
{

	if (n == 0)
		opcode(OP_LXI, 0, R_HL, "lxi h,0");
	else
		write_mul(n);
}

static unsigned gen_fast_div(unsigned s, unsigned n)
{
	int m = n - 1;

	if (cpu != 8085)
		return 0;

	if (n & (n - 1))
		return 0;

	opcode(OP_MOV, R_H, R_A, "mov a,h");
	opcode(OP_ORA, R_A, R_A, "ora a");
	opcode(OP_JUMP, R_A, 0, "jp X%u", ++label);
	/* We can trash DE */
	if (m > 0 && m <= 4)
		repeated_op("inx h", m);
	else if (m < 0 && m >= -4)
		repeated_op("dcx h", -m);
	else {
		opcode(OP_LXI, 0, R_HL, "lxi d,%u", (n - 1) & 0xFFFF);
		opcode(OP_DAD, R_DE|R_HL, R_HL, "dad d");
	}
	printf("X%u:\n", label);
	while(n > 1) {
		opcode(OP_ARHL, R_HL,  R_HL, "arhl");
		n >>= 1;
	}
	return 1;
}

static unsigned gen_fast_udiv(unsigned n, unsigned s)
{
	if (s != 2)
		return 0;
	if (n == 1)
		return 1;
	if (n == 256) {
		opcode(OP_MOV, R_H, R_L, "mov l,h");
		opcode(OP_MVI, 0, R_H, "mvi h,0");
		return 1;
	}
	return 0;
}

static unsigned gen_logicc(struct node *n, unsigned s, const char *op, unsigned v, unsigned code)
{
	unsigned h = (v >> 8) & 0xFF;
	unsigned l = v & 0xFF;

	if (s > 2 || (n && n->op != T_CONSTANT))
		return 0;

	/* If we are trying to be compact only inline the short ones */
	if (optsize && ((h != 0 && h != 255) || (l != 0 && l != 255)))
		return 0;

	if (s == 2) {
		if (h == 0) {
			if (code == 1)
				opcode(OP_MVI, 0, R_H, "mvi h,0");
		}
		else if (h == 255 && code != 3) {
			if (code == 2)
				opcode(OP_MVI, 0, R_H, "mvi h,255");
		} else {
			opcode(OP_MOV, R_H, R_A, "mov a,h");
			if (code == 3 && h == 255)
				printf("\tcpl\n");
			else
				printf("\t%s %u", op, h);
			opcode(OP_MOV, R_A, R_H, "mov h,a");
		}
	}
	if (l == 0) {
		if (code == 1)
			opcode(OP_MVI, 0, R_L, "mvi l,0");
	} else if (l == 255 && code != 3) {
		if (code == 2)
			opcode(OP_MVI, 0, R_L, "mvi l,255");
	} else {
		opcode(OP_MOV, R_L, R_A, "mov a,l");
		if (code == 3&& l == 255)
			printf("\tcpl\n");
		else
			printf("\t%s %u\n", op, l);
		opcode(OP_MOV, R_A, R_L, "mov l,a");
	}
	return 1;
}

static unsigned gen_fast_remainder(unsigned n, unsigned s)
{
	unsigned mask;
	if (s != 2)
		return 0;
	if (n == 1) {
		opcode(OP_LXI, 0, R_HL, "lxi h,0");
		return 1;
	}
	if (n == 256) {
		opcode(OP_MVI, 0, R_H, "mvi h,0\n");
		return 1;
	}
	if (n & (n - 1))
		return 0;
	if (!optsize) {
		mask = n - 1;
		gen_logicc(NULL, s, "ani", mask, 1);
		return 1;
	}
	return 0;
}

/*
 *	If possible turn this node into a direct access. We've already checked
 *	that the right hand side is suitable. If this returns 0 it will instead
 *	fall back to doing it stack based.
 *
 *	The 8080 is pretty basic so there isn't a lot we turn around here. As
 *	proof of concept we deal with the add case. Other processors may be
 *	able to handle a lot more.
 *
 *	If your processor is good at subtracts you may also want to rewrite
 *	constant on the left subtracts in the rewrite rules into some kind of
 *	rsub operator.
 */
unsigned gen_direct(struct node *n)
{
	unsigned s = get_size(n->type);
	struct node *r = n->right;
	unsigned v;
	unsigned nr = n->flags & NORETURN;

	/* We only deal with simple cases for now */
	if (r) {
		if (!access_direct(n->right))
			return 0;
		v = r->value;
	}

	switch (n->op) {
	case T_CLEANUP:
		gen_cleanup(v);
		return 1;
	case T_NSTORE:
		if (s > 2)
			return 0;
		if (s == 1)
			printf("\tmov a,l\n\tsta");
		else
			printf("\tshld ");
		printf("_%s+%u\n", namestr(n->snum), WORD(n->value));
			return 1;
		/* TODO 4/8 for long etc */
		return 0;
	case T_LBSTORE:
		if (s > 2)
			return 0;
		if (s == 1)
			printf("\tmov a,l\n\tsta");
		else
			printf("\tshld");
		printf(" T%u+%u\n", n->val2, v);
		return 1;
	case T_RSTORE:
		loadbc(s);
		return 1;
	case T_EQ:
		/* The address is in HL at this point */
		/* We have to avoid the right being an LREF because we need
		   HL and DE to resolve that sometimes, and the overhead
		   is worse than push/pop the non shortcut way */
		if (cpu == 8085 && s == 2 && r->op != T_LREF) {
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			if (load_hl_with(r) == 0)
				error("teq");
			printf("\tshlx\n");
			return 1;
		}
		if (s == 1) {
			/* We need to end up with the value in l if this is not NORETURN, also
			   we can optimize constant a step more */
			if (r->op == T_CONSTANT && nr)
				opcode(OP_MVI, R_HL, R_MEM, "mvi m,%u", ((unsigned)r->value) & 0xFF);
			else {
				if (load_a_with(r) == 0)
					return 0;
				opcode(OP_MOV, R_A|R_HL, R_MEM, "mov m,a");
				if (!nr)
					opcode(OP_MOV, R_A, R_L, "mov l,a");
			}
			return 1;
		}
		return 0;
	case T_PLUS:
		/* Zero should be eliminated in cc1 FIXME */
		if (r->op == T_CONSTANT) {
			if (v == 0)
				return 1;
			if (v < 4 && s <= 2) {
				if (s == 1)
					repeated_op("inr l", v);
				else
					repeated_op("inx h", v);
				return 1;
			}
		}
		if (s <= 2) {
			/* LHS is in HL at the moment, end up with the result in HL */
			if (s == 1) {
				if (load_a_with(r) == 0)
					return 0;
				opcode(OP_MOV, R_A, R_E, "mov e,a");
			}
			/* Short cut register case */
			if (r->op == T_REG) {
				opcode(OP_DAD, R_HL|R_BC, R_HL, "dad b");
				return 1;
			}
			if (s > 2 || load_de_with(r) == 0)
				return 0;
			opcode(OP_DAD, R_HL|R_DE, R_HL, "dad d");
			return 1;
		}
		return 0;
	case T_MINUS:
		if (r->op == T_CONSTANT) {
			if (v == 0)
				return 1;
			if (v < 6 && s <= 2) {
				if (s == 1)
					repeated_op("dcr l", v);
				else
					repeated_op("dcx h", v);
				return 1;
			}
			opcode(OP_LXI, 0, R_DE, "lxi d,%u", 65536 - v);
			opcode(OP_DAD, R_HL|R_DE, R_HL, "dad d");
			return 1;
		}
		if (cpu == 8085 && s <= 2)  {
			/* Shortcut subtracting register from working value */
			if (r->op == T_REG) {
				opcode(OP_DSUB, R_BC|R_HL, R_HL, "dsub");
				return 1;
			}
			if (access_direct_b(r)) {
				opcode(OP_PUSH, R_SP|R_BC, R_SP, "push b");
				sp += 2;
				/* Must not corrupt B before we are ready */
				/* LHS is in HL at the moment, end up with the result in HL */
				if (s == 1) {
					if (load_a_with(r) == 0)
						error("min1");
					opcode(OP_MOV, R_A, R_C, "mov c,a");
				} else {
					if (load_bc_with(r) == 0)
						error("min2");
				}
				opcode(OP_DSUB, R_BC|R_HL, R_HL, "dsub");
				opcode(OP_POP, R_SP, R_BC, "pop b");
				sp -= 2;
				return 1;
			}
		}
		return 0;
	case T_STAR:
		if (r->op == T_CONSTANT) {
			if (s <= 2 && can_fast_mul(s, r->value)) {
				gen_fast_mul(s, r->value);
				return 1;
			}
		}
		return gen_deop("mulde", n, r, 0);
	case T_SLASH:
		if (r->op == T_CONSTANT && s <= 2) {
			if (n->type & UNSIGNED) {
				if (gen_fast_udiv(s, v))
					return 1;
			} else {
				if (gen_fast_div(s, v))
					return 1;
			}
		}
		return gen_deop("divde", n, r, 1);
	case T_PERCENT:
		if (r->op == T_CONSTANT && (n->type & UNSIGNED)) {
			if (s <= 2 && gen_fast_remainder(s, r->value))
				return 1;
		}
		return gen_deop("remde", n, r, 1);
	case T_AND:
		if (gen_logicc(r, s, "ani", r->value, 1))
			return 1;
		return gen_deop("bandde", n, r, 0);
	case T_OR:
		if (gen_logicc(r, s, "ori", r->value, 2))
			return 1;
		return gen_deop("borde", n, r, 0);
	case T_HAT:
		if (gen_logicc(r, s, "xri", r->value, 3))
			return 1;
		return gen_deop("bxorde", n, r, 0);
	case T_EQEQ:
		return gen_compc("cmpeq", n, r, 0);
	case T_GTEQ:
		return gen_compc("cmpgteq", n, r, 1);
	case T_GT:
		return gen_compc("cmpgt", n, r, 1);
	case T_LTEQ:
		return gen_compc("cmplteq", n, r, 1);
	case T_LT:
		return gen_compc("cmplt", n, r, 1);
	case T_BANGEQ:
		return gen_compc("cmpne", n, r, 0);
	case T_LTLT:
		if (s <= 2 && r->op == T_CONSTANT && r->value <= 8) {
			if (r->value < 8)
				repeated_op("dad h", r->value);
			else {
				opcode(OP_MOV, R_L, R_H, "mov h,l");
				opcode(OP_MVI, 0, R_L, "mvi l,0");
			}
			return 1;
		}
		return gen_deop("shlde", n, r, 0);
	case T_GTGT:
		/* >> by 8 unsigned */
		if (s == 2 && (n->type & UNSIGNED) && r->op == T_CONSTANT && r->value == 8) {
			opcode(OP_MOV, R_H, R_L, "mov l,h");
			opcode(OP_MVI, 0, R_H, "mvi h,0");
			return 1;
		}
		/* 8085 has a signed right shift 16bit */
		if (cpu == 8085 && (!(n->type & UNSIGNED))) {
			if (s == 2 && r->op == T_CONSTANT && v < 8) {
				repeated_op("arhl", v);
				return 1;
			}
		}
		return gen_deop("shrde", n, r, 1);
	/* Shorten post inc/dec if result not needed - in which case it's the same as
	   pre inc/dec */
	case T_PLUSPLUS:
		if (!(n->flags & NORETURN))
			return 0;
	case T_PLUSEQ:
		if (s == 1) {
			if (r->op == T_CONSTANT && r->value < 4 && nr)
				repeated_op("inr m", r->value);
			else {
				if (load_a_with(r) == 0)
					return 0;
				printf("\tadd m\n\tmov m,a\n");
				if (!nr)
					printf("\tmov l,a\n");
			}
			return 1;
		}
		if (s == 2 && nr && r->op == T_CONSTANT && (r->value & 0x00FF) == 0) {
			opcode(OP_INC, R_HL, R_HL, "inx h");
			if ((r->value >> 8) < 4) {
				repeated_op("inr m", r->value >> 8);
				return 1;
			}
			opcode(OP_MVI, 0, R_A, "mvi a,%u", r->value >> 8);
			opcode(OP_ADD, R_MEM|R_HL|R_A, R_A, "add m");
			opcode(OP_MOV, R_A|R_HL, R_MEM, "mov m,a");
			return 1;
		}
		return gen_deop("pluseqde", n, r, 0);
	case T_MINUSMINUS:
		if (!(n->flags & NORETURN))
			return 0;
	case T_MINUSEQ:
		if (s == 1) {
			/* Shortcut for small 8bit values */
			if (r->op == T_CONSTANT && r->value < 4 && (n->flags & NORETURN)) {
				repeated_op("dcr m", r->value);
			} else {
				/* Subtraction is not transitive so this is
				   messier */
				if (r->op == T_CONSTANT) {
					if (r->value == 1)
						printf("\tmov a,m\n\tdcr a\n\tmov m,a");
					else
						printf("\tmov a,m\n\tsbi %u\n\tmov m,a",
							(int)r->value);
				} else {
					if (load_a_with(r) == 0)
						return 0;
					printf("\tcma\n\tinr a\n\n");
					printf("\tsub m\n\tmov m,a\n");
				}
				if (!(n->flags & NORETURN))
					printf("\tmov l,a\n");
			}
			return 1;
		}
		return gen_deop("minuseqde", n, r, 0);
	case T_ANDEQ:
		if (s == 1) {
			if (load_a_with(r) == 0)
				return 0;
			printf("\tana m\n\tmov m,a\n");
			if (!(n->flags & NORETURN))
				printf("\tmov l,a\n");
			return 1;
		}
		return gen_deop("andeqde", n, r, 0);
	case T_OREQ:
		if (s == 1) {
			if (load_a_with(r) == 0)
				return 0;
			printf("\tora m\n\tmov m,a\n");
			if (!(n->flags & NORETURN))
				printf("\tmov l,a\n");
			return 1;
		}
		return gen_deop("oreqde", n, r, 0);
	case T_HATEQ:
		if (s == 1) {
			if (load_a_with(r) == 0)
				return 0;
			printf("\txra m\n\tmov m,a\n");
			if (!(n->flags & NORETURN))
				printf("\tmov l,a\n");
			return 1;
		}
		return gen_deop("xoreqde", n, r, 0);
	}
	return 0;
}

/*
 *	Allow the code generator to shortcut the generation of the argument
 *	of a single argument operator (for example to shortcut constant cases
 *	or simple name loads that can be done better directly)
 */
unsigned gen_uni_direct(struct node *n)
{
	return 0;
}

static unsigned reg_canincdec(struct node *n, unsigned s, int v)
{
	/* We only deal with short and char for register */
	/* Is the shortcut worth it ? */
	if (n->op != T_CONSTANT || v > 8 || v < -8)
		return 0;
	return 1;
}

static unsigned reg_incdec(unsigned s, int v)
{
	if (s == 1) {
		if (v < 0)
			repeated_op("dcr c", -v);
		else
			repeated_op("inr c", v);
	} else {
		if (v < 0)
			repeated_op("dcx b", -v);
		else
			repeated_op("inx b", v);
	}
	return 1;
}

static void reg_logic(struct node *n, unsigned s, unsigned op, const char *i)
{
	/* TODO : constant optimization */
	codegen_lr(n->right);
	/* HL is now the value to combine with BC */
	if (opt > 1) {
		/* TODO - can avoid the reload into HL if NORETURN */
		if (s == 2)
			printf("\tmov a,b\n\t%s h\n\tmov b,a\nmov h,a\n", i + 2);
		printf("\tmov a,c\n\t%s c\n\tmov c,a\nmov l,a\n", i + 2);
	} else {
		helper(n, i);
		loadhl(n, s);
	}
}
/*
 *	Allow the code generator to short cut any subtrees it can directly
 *	generate.
 */
unsigned gen_shortcut(struct node *n)
{
	unsigned s = get_size(n->type);
	struct node *l = n->left;
	struct node *r = n->right;
	unsigned v;
	unsigned nr = n->flags & NORETURN;

	/* Unreachable code we can shortcut into nothing whee.be.. */
	if (unreachable)
		return 1;

	/* The comma operator discards the result of the left side, then
	   evaluates the right. Avoid pushing/popping and generating stuff
	   that is surplus */
	if (n->op == T_COMMA) {
		l->flags |= NORETURN;
		codegen_lr(l);
		/* Parent determines child node requirements */
		r->flags |= nr;
		codegen_lr(r);
		return 1;
	}
	/* We don't know if the result has set the condition flags
	 * until we generate the subtree. So generate the tree, then
	 * either do nice things or use the helper */
	if (n->op == T_BOOL) {
		codegen_lr(r);
		if (r->flags & ISBOOL)
			return 1;
		s = get_size(r->type);
		if (s <= 2 && (n->flags & CCONLY)) {
			if (s == 2)
				printf("\tmov a,h\n\tora l\n");
			else
				printf("\tmov a,l\n\tora a\n");
			return 1;
		}
		/* Too big or value needed */
		helper(n, "bool");
		n->flags |= ISBOOL;
		return 1;
	}
	/* Re-order assignments we can do the simple way */
	if (n->op == T_NSTORE && s <= 2) {
		codegen_lr(r);
		/* Expression result is now in HL */
		if (s == 2)
			printf("\tshld");
		else
			printf("\tmov a,l\n\tsta");
		printf(" _%s+%u\n", namestr(n->snum), WORD(n->value));
		return 1;
	}
	/* Locals we can do on 8085, 8080 is doable but messy - so not worth it */
	if (n->op == T_LSTORE && s <= 2) {
		if (n->value + sp == 0 && s == 2) {
			/* The one case 8080 is worth doing */
			codegen_lr(r);
			if (n->flags & NORETURN)
				printf("\txthl\n");
			else
				printf("\tpop psw\n\tpush h\n");
			return 1;
		}
		if (cpu == 8085 && n->value + sp < 255) {
			codegen_lr(r);
			opcode(OP_LDSI, R_SP, R_DE, "ldsi %u",WORD(n->value + sp));
			if (s == 2)
				printf("\tshlx\n");
			else
				printf("\tmov a,l\n\tstax d\n");
			return 1;
		}
	}
	/* Shortcut any initialization of BC we can do directly */
	if (n->op == T_RSTORE && nr) {
		if (load_bc_with(r))
			return 1;
		return 0;
	}
	/* Assignment to *BC, byte pointer always */
	if (n->op == T_REQ) {
		unsigned in_l = 0;
		/* Try and get the value into A */
		if (!load_a_with(r)) {
			codegen_lr(r);		/* If not then into HL */
			in_l = 1;
			opcode(OP_MOV, R_L, R_A, "mov a,l");
		}
		printf("\tstax b\n");	/* Do in case volatile */
		if (!nr && !in_l)
			opcode(OP_MOV, R_A, R_L, "mov l,a");
		return 1;
	}
	if (n->op == T_AND && l->op == T_RREF) {
		if (s == 1) {
			if (!load_a_with(r))
				return 0;
			opcode(OP_ANA, R_A|R_C, R_A, "ana c");
			opcode(OP_MOV, R_A, R_L, "mov l,a");
			return 1;
		}
		/* And of register and constant */
		if (s == 2 && r->op == T_CONSTANT) {
			v = r->value;
			if ((v & 0xFF00) == 0x0000)
				opcode(OP_MVI, 0, R_H, "mvi h,0");
			else if ((v & 0xFF00) != 0xFF00) {
				opcode(OP_MVI, 0, R_A, "mvi a, %u", v >> 8);
				opcode(OP_ANA, R_B, R_A, "ana b");
				opcode(OP_MOV, R_A, R_H, "mov h,a");
			} else
				opcode(OP_MOV, R_B, R_H, "mov h,b");

			if ((v & 0xFF) == 0x00)
				opcode(OP_MVI, 0, R_L, "mvi l,0");
			else if ((v & 0xFF) != 0xFF) {
				opcode(OP_MVI, 0, R_A, "mvi a, %u", v & 0xFF);
				opcode(OP_ANA, R_C, R_A, "ana c");
				opcode(OP_MOV, R_A, R_L, "mov l,a");
			} else
				opcode(OP_MOV, R_C, R_L, "mov l,c");

			return 1;
		}
	}
	if (n->op == T_OR && l->op == T_RREF) {
		if (s == 1) {
			if (!load_a_with(r))
				return 0;
			opcode(OP_ORA, R_A|R_C, R_A, "ora c");
			opcode(OP_MOV, R_A, R_L, "mov l,a");
			return 1;
		}
		/* or of register and constant */
		if (s == 2 && r->op == T_CONSTANT) {
			v = r->value;
			if ((v & 0xFF00) == 0xFF00)
				opcode(OP_MVI, 0, R_H, "mvi h,0xff");
			else if (v & 0xFF00) {
				opcode(OP_MVI, 0, R_A, "mvi a, %u", v >> 8);
				opcode(OP_ORA, R_B, R_A, "ora b");
				opcode(OP_MOV, R_A, R_H, "mov h,a");
			}
			if ((v & 0xFF) == 0xFF)
				opcode(OP_MVI, 0, R_L, "mvi l,0xff");
			else if (v & 0xFF) {
				opcode(OP_MVI, 0, R_A, "mvi a, %u", v & 0xFF);
				opcode(OP_ORA, R_C, R_A, "ana c");
				opcode(OP_MOV, R_A, R_L, "mov l,a");
			}
			return 1;
		}
	}
	/* ?? LBSTORE */
	/* Register targetted ops. These are totally different to the normal EQ ops because
	   we don't have an address we can push and then do a memory op */
	if (l && l->op == T_REG) {
		v = r->value;
		switch(n->op) {
		case T_PLUSPLUS:
			if (reg_canincdec(r, s, v)) {
				loadhl(n, s);
				reg_incdec(s, v);
				return 1;
			}
			if (!nr) {
				printf("\tpush b\n");
				sp += 2;
			}
			/* Fall through */
		case T_PLUSEQ:
			if (reg_canincdec(r, s, v)) {
				reg_incdec(s, v);
				if (nr)
					return 1;
				if (n->op == T_PLUSEQ) {
					loadhl(n, s);
				}
			} else {
				/* Amount to add into HL */
				codegen_lr(r);
				opcode(OP_DAD, R_HL|R_BC, R_HL, "dad b");
				opcode(OP_MOV, R_L, R_C, "mov c,l");
				if (s == 2)
					opcode(OP_MOV, R_H, R_B, "mov b,h");
			}
			if (n->op == T_PLUSPLUS && !(n->flags & NORETURN)) {
				opcode(OP_POP, R_SP, R_HL|R_SP, "pop h");
				sp -= 2;
			}
			return 1;
		case T_MINUSMINUS:
			if (!(n->flags & NORETURN)) {
				if (reg_canincdec(r, s, -v)) {
					loadhl(n, s);
					reg_incdec(s, -v);
					return 1;
				}
				codegen_lr(r);
				if (s == 1) {
					printf("\tmov a,c\n\tsub l\n\tmov l,c\n\tmov c,a\n");
					return 1;
				}
				/* Not worth messing with inlined constants as we need the original value */
				helper(n, "bcsub");
				return 1;
			}
			/* If we don't care about the return they look the same so fall
			   through */
		case T_MINUSEQ:
			if (reg_canincdec(r, s, -v)) {
				reg_incdec(s, -v);
				loadhl(n, s);
				return 1;
			}
			if (r->op == T_CONSTANT) {
				opcode(OP_LXI, 0, R_HL, "lxi h,%u", -v);
				opcode(OP_DAD, R_HL|R_BC, R_HL, "dad b");
				loadbc(s);
				return 1;
			}
			/* Get the subtraction value into HL */
			codegen_lr(r);
			helper(n, "bcsub");
			/* Result is only left in BC reload if needed */
			loadhl(n, s);
			return 1;
		/* For now - we can do better - maybe just rewrite them into load,
		   op, store ? */
		case T_STAREQ:
			/* TODO: constant multiply */
			if (r->op == T_CONSTANT) {
				if (can_fast_mul(s, v)) {
					loadhl(NULL, s);
					gen_fast_mul(s, v);
					loadbc(s);
					return 1;
				}
			}
			codegen_lr(r);
			helper(n, "bcmul");
			return 1;
		case T_SLASHEQ:
			/* TODO: power of 2 constant divide maybe ? */
			codegen_lr(r);
			helper_s(n, "bcdiv");
			return 1;
		case T_PERCENTEQ:
			/* TODO: spot % 256 case */
			codegen_lr(r);
			helper(n, "bcrem");
			return 1;
		case T_SHLEQ:
			if (r->op == T_CONSTANT) {
				if (s == 1 && v >= 8) {
					opcode(OP_MVI, 0, R_C, "mvi c,0");
					loadhl(n, s);
					return 1;
				}
				if (s == 1) {
					printf("\tmov a,c\n");
					repeated_op("add a", v);
					printf("\tmov c,a\n");
					loadhl(n, s);
					return 1;
				}
				/* 16 bit */
				if (v >= 16) {
					opcode(OP_LXI, 0, R_B, "lxi b,0");
					loadhl(n, s);
					return 1;
				}
				if (v == 8) {
					printf("\tmov b,c\n\tmvi c,0\n");
					loadhl(n, s);
					return 1;
				}
				if (v > 8) {
					printf("\tmov a,c\n");
					repeated_op("add a", v - 8);
					printf("\tmov b,a\nvi c,0\n");
					loadhl(n, s);
					return 1;
				}
				/* 16bit full shifting */
				loadhl(NULL, s);
				repeated_op("dad h", v);
				loadbc(s);
				return 1;
			}
			codegen_lr(r);
			helper(n, "bcshl");
			return 1;
		case T_SHREQ:
			if (r->op == T_CONSTANT) {
				if (v >= 8 && s == 1) {
					opcode(OP_MVI, 0, R_C, "mvi c,0");
					loadhl(n, s);
					return 1;
				}
				if (v >= 16) {
					opcode(OP_LXI, 0, R_BC, "lxi b,0");
					loadhl(n, s);
					return 1;
				}
				if (v == 8 && (n->type & UNSIGNED)) {
					printf("\tmov c,b\nmvi b,0\n");
					loadhl(n, s);
					return 1;
				}
				if (s == 2 && !(n->type & UNSIGNED) && cpu == 8085 && v < 2 + 4 * opt) {
					loadhl(NULL,s);
					repeated_op("arhl", v);
					loadbc(s);
					return 1;
				}
			}
			codegen_lr(r);
			helper_s(n, "bcshr");
			return 1;
		case T_ANDEQ:
			reg_logic(n, s, 0, "bcana");
			return 1;
		case T_OREQ:
			reg_logic(n, s, 1, "bcora");
			return 1;
		case T_HATEQ:
			reg_logic(n, s, 2, "bcxra");
			return 1;
		}
	}
	return 0;
}

/* Stack the node which is currently in the working register */
unsigned gen_push(struct node *n)
{
	unsigned size = get_stack_size(n->type);

	/* Our push will put the object on the stack, so account for it */
	sp += size;

	switch(size) {
	case 2:
		opcode(OP_PUSH, R_SP|R_HL, R_SP, "push h");
		return 1;
	case 4:
		if (optsize)
			opcode(OP_CALL, R_HL, R_BC|R_DE|R_HL|R_PSW, "call __pushl");
		else {
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			opcode(OP_LHLD, R_M, R_HL, "lhld __hireg");
			opcode(OP_PUSH, R_SP|R_HL, R_SP, "push h");
			opcode(OP_PUSH, R_SP|R_DE, R_SP, "push d");
		}
		return 1;
	default:
		return 0;
	}
}

static unsigned gen_cast(struct node *n)
{
	unsigned lt = n->type;
	unsigned rt = n->right->type;
	unsigned ls;

	if (PTR(rt))
		rt = USHORT;
	if (PTR(lt))
		lt = USHORT;

	/* Floats and stuff handled by helper */
	if (!IS_INTARITH(lt) || !IS_INTARITH(rt))
		return 0;

	ls = get_size(lt);

	/* Size shrink is free */
	if ((lt & ~UNSIGNED) <= (rt & ~UNSIGNED))
		return 1;
	/* Don't do the harder ones */
	if (!(rt & UNSIGNED) || ls > 2)
		return 0;
	opcode(OP_MVI, 0, R_H, "mvi h,0");
	return 1;
}

unsigned gen_node(struct node *n)
{
	unsigned size = get_size(n->type);
	unsigned v;
	char *name;
	unsigned nr = n->flags & NORETURN;
	/* We adjust sp so track the pre-adjustment one too when we need it */

	v = n->value;

	/* An operation with a left hand node will have the left stacked
	   and the operation will consume it so adjust the stack.

	   The exception to this is comma and the function call nodes
	   as we leave the arguments pushed for the function call */

	if (n->left && n->op != T_ARGCOMMA && n->op != T_CALLNAME && n->op != T_FUNCCALL)
		sp -= get_stack_size(n->left->type);

	switch (n->op) {
		/* Load from a name */
	case T_NREF:
		if (size == 1) {
			opcode(OP_LDA, R_M, R_A, "lda _%s+%u", namestr(n->snum), v);
			opcode(OP_MOV, R_A, R_L, "mov l,a");
		} else if (size == 2) {
			opcode(OP_LHLD, R_M, R_HL, "lhld _%s+%u\n", namestr(n->snum), v);
			return 1;
		} else if (size == 4) {
			printf("\tlhld _%s+%u\n", namestr(n->snum), v + 2);
			printf("\tshld __hireg\n");
			printf("\tlhld _%s+%u\n", namestr(n->snum), v);
		} else
			error("nrb");
		return 1;
	case T_LBREF:
		if (size == 1) {
			printf("\tlda T%u+%u\n", n->val2, v);
			printf("\tmov l,a\n");
		} else if (size == 2) {
			printf("\tlhld T%u+%u\n", n->val2, v);
		} else if (size == 4) {
			printf("\tlhld T%u+%u\n", n->val2, v + 2);
			printf("\tshld __hireg\n");
			printf("\tlhld T%u+%u\n", n->val2, v);
		} else
			error("lbrb");
		return 1;
	case T_LREF:
		/* We are loading something then not using it, and it's local
		   so can go away */
		/* printf(";L sp %u %s(%ld)\n", sp, namestr(n->snum), n->value); */
		if (nr)
			return 1;
		v += sp;
		return gen_lref(v, size, 0);
	case T_RREF:
		if (nr)
			return 1;
		opcode(OP_MOV, R_C, R_L, "mov l,c");
		if (size == 2)
			opcode(OP_MOV, R_B, R_H, "mov h,b");
		return 1;
	case T_NSTORE:
		if (size == 4) {
			opcode(OP_SHLD, R_HL, R_M, "shld %s+%u", namestr(n->snum), v);
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			opcode(OP_LHLD, R_M, R_HL, "lhld __hireg");
			opcode(OP_SHLD, R_HL, R_M, "shld %s+%u\n",
				namestr(n->snum), v + 2);
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			return 1;
		}
		if (size == 1)
			printf("\tmov a,l\n\tsta");
		else
			printf("\tshld");
		printf(" _%s+%u\n", namestr(n->snum), v);
		return 1;
	case T_LBSTORE:
		if (size == 4) {
			printf("\tshld T%u+%u\n", n->val2, v);
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			printf("\tlhld __hireg\n\tshld T%u+%u\n",
				n->val2, v + 2);
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			return 1;
		}
		if (size == 1) {
			opcode(OP_MOV, R_L, R_A, "mov a,l");
			opcode(OP_STA, R_A, R_M, "sta T%u+%u\n", n->val2, v);
		} else
			opcode(OP_SHLD, R_HL, R_M, "shld T%u+%u\n", n->val2, v);
		return 1;
	case T_LSTORE:
/*		printf(";L sp %u spval %u %s(%ld)\n", sp, spval, namestr(n->snum), n->value); */
		v += sp;
		if (v == 0 && size == 2 ) {
			if (nr)
				opcode(OP_XTHL, R_SP|R_M|R_HL, R_SP|R_M|R_HL, "xthl");
			else {
				opcode(OP_POP, R_SP, R_PSW|R_SP, "pop psw");
				opcode(OP_PUSH, R_SP|R_HL, R_SP, "push h");
			}
			return 1;
		}
		if (cpu == 8085 && v <= 255) {
			opcode(OP_LDSI, R_DE, R_DE, "ldsi %u", v);
			if (size == 2)
				opcode(OP_SHLX, R_DE|R_HL, R_M, "shlx");
			else {
				opcode(OP_MOV, R_L, R_A, "mov a,l");
				opcode(OP_STAX, R_DE|R_A, R_M, "stax d\n");
			}
			return 1;
		}
		if (v == 2 && size == 2) {
			opcode(OP_POP, R_SP, R_DE|R_SP, "pop d");
			if (nr)
				opcode(OP_XTHL, R_SP|R_M|R_HL, R_SP|R_M|R_HL, "xthl");
			else {
				opcode(OP_POP, R_SP, R_PSW|R_SP, "pop psw");
				opcode(OP_PUSH, R_SP|R_HL, R_SP, "push h");
			}
			opcode(OP_PUSH, R_SP, R_DE|R_SP, "push d");
			return 1;
		}
		/* Large offsets for word on 8085 are 7 bytes, a helper call is 5 (3 with rst hacks)
		   and much slower. As these are fairly rare just inline it */
		if (cpu == 8085 && size == 2) {
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			opcode(OP_LXI, 0, R_HL,  "lxi h,%u", WORD(v));
			opcode(OP_DAD, R_HL|R_SP, R_HL, "dad sp");
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			opcode(OP_SHLX, R_HL|R_DE, R_M, "shlx");
			return 1;
		}
		if (size == 1 && (!optsize || v >= LWDIRECT)) {
			printf("\tmov a,l\n\tlxi h,%u\n\tdad sp\n\tmov m,a\n", WORD(v));
			if (!nr)
				printf("\tmov l,a\n");
			return 1;
		}
		/* For -O3 they asked for it so inline the lot */
		/* We dealt with size one above */
		if (opt > 2 && size == 2) {
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			printf("\tlxi h,%u\n\tdad sp\n\tmov m,e\n\tinx h\n", WORD(v));
			printf("\tmov m,d\n");
			if (!nr)
				opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			return 1;
		}
		/* Via helper magic for compactness on 8080 */
		/* Can rewrite some of them into rst if need be */
		if (size == 1)
			name = "stbyte";
		else if (size == 2)
			name = "stword";
		/* FIXME */
		else
			return 0;
		/* Like load the helper is offset by two because of the
		   stack */
		if (v < 24)
			printf("\tcall __%s%u\n", name, v + 2);
		else if (v < 253)
			printf("\tcall __%s\n\t.byte %u\n", name, v + 2);
		else
			printf("\tcall __%sw\n\t.word %u\n", name, v + 2);
		return 1;
	case T_RSTORE:
		loadbc(size);
		return 1;
		/* Call a function by name */
	case T_CALLNAME:
		opcode(OP_CALL, 0, R_BC|R_DE|R_HL|R_PSW, "call _%s+%u", namestr(n->snum), v);
		return 1;
	case T_EQ:
		if (size == 2) {
			if (cpu == 8085) {
				opcode(OP_POP, R_SP, R_SP|R_DE, "pop d");
				opcode(OP_SHLX, R_DE|R_HL, R_M, "shlx");
			} else {
				opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
				printf("\tpop h\n\tmov m,e\n\tinx h\n\tmov m,d\n");
				if (!(nr))
					opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			}
			return 1;
		}
		if (size == 1) {
			opcode(OP_POP, R_SP, R_SP|R_DE, "pop d");
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			opcode(OP_MOV, R_E, R_M|R_HL, "mov m,e");
			if (!(n->flags & NORETURN))
				opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			return 1;
		}
		break;
	case T_RDEREF:
		/* RREFs on 8080 will always be byte pointers */
		/* Can't get rid of the ldax until we have proper volatiles */
		opcode(OP_LDAX, R_M|R_BC, R_A, "ldax b");
		if (!(n->flags & NORETURN))
			opcode(OP_MOV, R_A, R_L, "mov l,a");
		return 1;
	case T_DEREF:
		if (size == 2) {
			if (cpu == 8085) {
				opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
				opcode(OP_LHLX, R_DE|R_MEM, R_HL, "lhlx");
			} else {
				opcode(OP_MOV, R_M|R_HL, R_E, "mov e,m");
				opcode(OP_INX, R_HL, R_HL, "inx h");
				opcode(OP_MOV, R_M|R_HL, R_D, "mov d,m");
				opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			}
			return 1;
		}
		if (size == 1) {
			opcode(OP_MOV, R_HL|R_M, R_L, "mov l,m");
			return 1;
		}
		if (size == 4 && cpu == 8085 && !optsize) {
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
			opcode(OP_INX, R_DE, R_DE, "inx d");
			opcode(OP_INX, R_DE, R_DE, "inx d");
			opcode(OP_LHLX, R_DE|R_M, R_HL, "lhlx");
			opcode(OP_SHLD, R_HL, R_M, "shld __hireg");
			opcode(OP_INX, R_DE, R_DE, "dcx d");
			opcode(OP_INX, R_DE, R_DE, "dcx d");
			opcode(OP_LHLX, R_DE|R_M, R_HL, "lhlx");
			return 1;
		}
		break;
	case T_FUNCCALL:
		opcode(OP_CALL, R_HL, R_BC|R_DE|R_HL|R_PSW, "\tcall __callhl\n");
		return 1;
	case T_LABEL:
		if (nr)
			return 1;
		/* Used for const strings and local static */
		opcode(OP_LXI, 0, R_HL, "lxi h,T%u+%u", n->val2, v);
		return 1;
	case T_CONSTANT:
		if (nr)
			return 1;
		switch(size) {
		case 4:
			opcode(OP_LXI, 0, R_HL, "lxi h,%u\n", ((n->value >> 16) & 0xFFFF));
			opcode(OP_SHLD, R_HL, R_MEM, "shld __hireg");
		case 2:
			opcode(OP_LXI, 0, R_HL, "lxi h,%u", v & 0xFFFF);
			return 1;
		case 1:
			opcode(OP_MVI, 0, R_L, "mvi l,%u", v & 0xFF);
			return 1;
		}
		break;
	case T_NAME:
		if (nr)
			return 1;
		opcode(OP_LXI, 0, R_HL, "lxi h, _%s+%u", namestr(n->snum), v);
		return 1;
	/* FIXME: LBNAME ?? */
	case T_LOCAL:
		if (nr)
			return 1;
		v += sp;
/*		printf(";LO sp %u spval %u %s(%ld)\n", sp, spval, namestr(n->snum), n->value); */
		if (cpu == 8085 && v <= 255) {
			opcode(OP_LDSI, R_DE|R_SP, R_DE, "ldsi %u", v);
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
		} else {
			opcode(OP_LXI, 0, R_HL, "lxi h,%u", v);
			opcode(OP_DAD, R_SP|R_HL, R_HL, "dad sp");
		}
		return 1;
	case T_ARGUMENT:
		if (nr)
			return 1;
		v += frame_len + argbase + sp;
/*		printf(";AR sp %u spval %u %s(%ld)\n", sp, spval, namestr(n->snum), n->value); */
		if (cpu == 8085 && v <= 255) {
			opcode(OP_LDSI, R_DE|R_SP, R_DE, "ldsi %u", v);
			opcode(OP_XCHG, R_DE|R_HL, R_DE|R_HL, "xchg");
		} else {
			opcode(OP_LXI, 0, R_HL, "lxi h,%u", v);
			opcode(OP_DAD, R_SP|R_HL, R_HL, "dad sp");
		}
		return 1;
	case T_REG:
		if (nr)
			return 1;
		/* A register has no address.. we need to sort this out */
		error("rega");
		return 1;
	case T_CAST:
		if (nr)
			return 1;
		return gen_cast(n);
	case T_PLUS:
		if (size <= 2) {
			opcode(OP_POP, R_SP, R_SP|R_DE, "pop d");
			opcode(OP_DAD, R_HL|R_DE, R_HL, "dad d");
			return 1;
		}
		break;
	}
	return 0;
}