feat: use pathlib to replace os.path for handling file path
#331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100gle
force-pushed
the
refactor/use-pathlib-to-replace-os-path
branch
3 times, most recently
from
f267a52
to
d5247d5
Compare
zthxxx
reviewed
Jul 3, 2023
100gle
force-pushed
the
refactor/use-pathlib-to-replace-os-path
branch
from
d5247d5
to
7fdf813
Compare
|
everything is done. @zthxxx |
|
LGTM @EstrellaXD |
|
@zthxxx hold on, there are some parts that haven't changed. |
|
@zthxxx everything is ok. Please go ahead. |
zthxxx
reviewed
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @EstrellaXD