Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display distances in locale distance units #51

Open
doneill opened this issue Dec 7, 2016 · 3 comments
Open

Display distances in locale distance units #51

doneill opened this issue Dec 7, 2016 · 3 comments

Comments

@doneill
Copy link
Contributor

doneill commented Dec 7, 2016

Currently the distances are presented in meters, we should present the in metric by default but use imperial for US. Distances should then be displayed in KM (metric) or Mi (mperial):

Example of miles output, need to change m to mi:
miles

Change meters to miles in route directions:
miles2

@justincolville
Copy link

Anyway to set this based on the device locale? Being from... the rest of the world... km sounds like a better unit to me :)

@doneill
Copy link
Contributor Author

doneill commented Dec 21, 2016

@justincolville, Yes that would be an improvement question for consideration is whether we want to handle this programmatically based on device locale or as a user setting?

@doneill doneill modified the milestones: Minor Update 1, Version 1.0.0 Dec 21, 2016
@doneill doneill changed the title Display distances in Miles Display distances in locale distance units Jan 12, 2017
@doneill
Copy link
Contributor Author

doneill commented Jan 12, 2017

I updated the title/description to incorporate @justincolville comment.

@mikewilburn mikewilburn removed this from the Minor Update 1 milestone Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants