Skip to content
This repository has been archived by the owner on Jan 12, 2018. It is now read-only.

Does not work if defaultJSExtensions: true is used #25

Closed
DaveEmmerson opened this issue Nov 17, 2016 · 2 comments
Closed

Does not work if defaultJSExtensions: true is used #25

DaveEmmerson opened this issue Nov 17, 2016 · 2 comments

Comments

@DaveEmmerson
Copy link

In our project, we set defaultJSExtensions: true in our config.js, this is to fit in with the template we're using.

This doesn't play well with esri-system-js. When getName is called, the location it is passed isn't, e.g., esri/Color, it's esri/Color.js.

The result is that in _register, the name doesn't match the supplied list of module names and the modules aren't registered with SystemJS.

I've fixed the issue in a fork that we're going to use, but I was wondering if the change might be included in the library itself? I can submit a pull request if it's seen to be a good thing.

Thanks

Dave

@DaveEmmerson
Copy link
Author

It might be that a config.js change can fix this. Thinking a package for esri that does defaultExtension: false.

Will update if I figure it out.

@DaveEmmerson
Copy link
Author

The answer was:

"esri": {
  "defaultExtension": false
}

In the config.js

Ah well, I've learned a lot about our setup and about esri-system-js in the process :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant