Skip to content

Commit deb0b10

Browse files
committed
linting, no bower_components in tarball
1 parent a865e3a commit deb0b10

File tree

5 files changed

+33
-34
lines changed

5 files changed

+33
-34
lines changed

.npmignore

+2
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,5 @@ examples
3434
js
3535

3636
*.zip
37+
38+
bower_components/

README.md

+2-5
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
[![Build Status](https://travis-ci.org/Esri/cedar.svg?branch=v0.x)](https://travis-ci.org/Esri/cedar)
44

5-
> **NOTE:** You're looking at the documentation for v0.x, but v1.x is in beta. For more info, see [the v1.x (beta) documentation](https://github.com/Esri/cedar)
5+
> **NOTE:** You're looking at the documentation for v0.x, but v1.x is in beta. For more info, see [the v1.x documentation](https://github.com/Esri/cedar)
66
77
Cedar is a library for crafting, sharing and data visualizations powered by ArcGIS Services. Built with D3 and the Vega graphics grammar, Cedar extends them with bindings for making templated chart graphics that can be re-used with different datasets.
88

@@ -172,7 +172,7 @@ For more information on SemVer, please visit <http://semver.org/>.
172172

173173

174174
### Licensing
175-
Copyright 2015 Esri
175+
Copyright &copy; 2015 Esri Inc.
176176

177177
Licensed under the Apache License, Version 2.0 (the "License");
178178
you may not use this file except in compliance with the License.
@@ -187,6 +187,3 @@ See the License for the specific language governing permissions and
187187
limitations under the License.
188188

189189
A copy of the license is available in the repository's [LICENSE](./LICENSE) file.
190-
191-
[](Esri Tags: Visualization)
192-
[](Esri Language: JavaScript)

src/cedar.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -706,7 +706,7 @@ export default class Cedar {
706706
});
707707
}
708708

709-
/**
709+
/**
710710
* EVENT LOGIC HERE
711711
*
712712
*
@@ -857,7 +857,7 @@ export default class Cedar {
857857
return items;
858858
}
859859

860-
/**
860+
/**
861861
* Removes highlighted chart items
862862
*
863863
* If "options" are used, only clear specific items, otherwise clears all highlights.

src/utils/request.js

+21-21
Original file line numberDiff line numberDiff line change
@@ -101,27 +101,27 @@ export function createFeatureServiceRequest (dataset, queryFromSpec) {
101101
}]);
102102
}
103103

104-
// iterate the mappings keys to check for sort
105-
// -----------------------------------------------------------------
106-
// This approach would seem 'clean' but if there are multiple fields
107-
// to sort by, the order would be determined by how javascript decides to
108-
// iterate the mappings property hash.
109-
// Thus, using mappings.sort gives the developer explicit control
110-
// -----------------------------------------------------------------
111-
// var sort = [];
112-
// for (var property in dataset.mappings) {
113-
// if (dataset.mappings.hasOwnProperty(property)) {
114-
// if(dataset.mappings[property].sort){
115-
// //ok - build up the sort
116-
// sort.push(dataset.mappings[property].field + ' ' + dataset.mappings[property].sort);
117-
// }
118-
// }
119-
// }
120-
// if(sort.length > 0){
121-
// mergedQuery.orderByFields = sort.join(',');
122-
// }
123-
// -----------------------------------------------------------------
124-
// check for a sort passed directly in
104+
// iterate the mappings keys to check for sort
105+
// -----------------------------------------------------------------
106+
// This approach would seem 'clean' but if there are multiple fields
107+
// to sort by, the order would be determined by how javascript decides to
108+
// iterate the mappings property hash.
109+
// Thus, using mappings.sort gives the developer explicit control
110+
// -----------------------------------------------------------------
111+
// var sort = [];
112+
// for (var property in dataset.mappings) {
113+
// if (dataset.mappings.hasOwnProperty(property)) {
114+
// if(dataset.mappings[property].sort){
115+
// //ok - build up the sort
116+
// sort.push(dataset.mappings[property].field + ' ' + dataset.mappings[property].sort);
117+
// }
118+
// }
119+
// }
120+
// if(sort.length > 0){
121+
// mergedQuery.orderByFields = sort.join(',');
122+
// }
123+
// -----------------------------------------------------------------
124+
// check for a sort passed directly in
125125

126126
if (dataset.mappings.sort) {
127127
mergedQuery.orderByFields = dataset.mappings.sort;

src/utils/utils.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export function getTokenValue (tokens, tokenName) {
7878
return tmpTokens;
7979
}
8080

81-
/**
81+
/**
8282
* Helper function that validates that the
8383
* mappings hash contains values for all
8484
* the inputs
@@ -95,7 +95,7 @@ export function validateMappings (inputs, mappings) {
9595
});
9696
}
9797

98-
/**
98+
/**
9999
* Validate that the incoming data has the fields expected
100100
* in the mappings
101101
* @access private
@@ -117,7 +117,7 @@ export function validateData (data, mappings) {
117117
return missingInputs;
118118
}
119119

120-
/**
120+
/**
121121
* TODO does nothing, must figure out.
122122
* Centralize and abstract the computation of
123123
* expected field names, based on the mapping name
@@ -127,9 +127,9 @@ export function getMappingFieldName (mappingName, fieldName) {
127127
// this function why?
128128

129129
let name = fieldName;
130-
// if(mappingName.toLowerCase() === 'count'){
131-
// name = fieldName + '_SUM';
132-
// }
130+
// if(mappingName.toLowerCase() === 'count'){
131+
// name = fieldName + '_SUM';
132+
// }
133133
return name;
134134
}
135135

0 commit comments

Comments
 (0)