Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): lint readme and changelog before committing #6406

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

benelan
Copy link
Member

@benelan benelan commented Feb 1, 2023

Related Issue: #6355

Summary

I added markdown lint in the PR above but it isn't running during releases because we have standard-version set to noVerify. So this is manually linting the readme/changelog before committing.

@benelan benelan requested a review from a team as a code owner February 1, 2023 03:01
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Feb 1, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨🧹✨

@benelan benelan merged commit 771a988 into master Feb 2, 2023
@benelan benelan deleted the benelan/lint-changelog branch February 2, 2023 18:48
benelan added a commit that referenced this pull request Feb 3, 2023
* origin/master:
  docs(input-number, input-text): remove unsupported boolean type from type prop doc (#6394)
  ci(release): lint readme and changelog before committing (#6406)
  ci: allow multiple product team labels (#6411)
benelan added a commit that referenced this pull request Feb 8, 2023
**Related Issue:** #6406

## Summary

The commit messages for `next` releases are goofed. This removes our
custom `{{currentTag}}` commit message and replaces it with the default:
`chore(release): {{currentTag}}`

It also removes `noVerify` so we can remove `npm run lint:md` from 
standard-version's pre-commit hook because it will be done by `lint-staged`.

The commit message was fine before the PR linked above. No idea why this
is happening but it's probably a `standard-version` bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants