fix(tree): restore tabbing through items#14441
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Restores the box-shadow on calcite-sheet by targeting the correct internal element (.content instead of .container), and adds a story to visualize the shadow across modes and positions. Also includes an unrelated tree focus fix.
Changes:
- Update sheet SCSS selectors to apply
box-shadowon.contentrather than.container. - Add a new story
shadowAcrossModesAndPositionsto demonstrate sheet shadows. - Adjust tree's
focusElementcall and add a browser e2e test for tree focus behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/components/src/components/sheet/sheet.scss | Move shadow rules from .container to .content to restore visible shadow. |
| packages/components/src/components/sheet/sheet.stories.ts | Add story covering shadow rendering across display modes and positions. |
| packages/components/src/components/tree/tree.tsx | Pass additional args to focusElement for focusable target resolution. |
| packages/components/src/components/tree/tree.browser.e2e.tsx | Add browser e2e test verifying tab focus order in tree with slotted action. |
github-actions
Bot
added
the
bug
jcfranco
force-pushed
the
jcfranco/14362-restore-sheet-shadow
branch
from
92ca6cf to
d04f1d5
Compare
jcfranco
changed the title
jcfranco
added
the
skip visual snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #13938
Summary
Fixes a regression from #11943 that prevented items from being tabbed through if they contained focusable elements.