Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Add validation for consistency #7354

Closed
2 of 7 tasks
geospatialem opened this issue Jul 21, 2023 · 2 comments
Closed
2 of 7 tasks

[Select] Add validation for consistency #7354

geospatialem opened this issue Jul 21, 2023 · 2 comments
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ready for dev Issues ready for development implementation.

Comments

@geospatialem
Copy link
Member

geospatialem commented Jul 21, 2023

Check existing issues

Description

Add validation for consistency across the design system to the select component

Acceptance Criteria

  • Add a required prop
  • Add an invalid prop
    • triggers:
      • required
  • Deprecate the status prop in favor of an invalid pop as they might not be needed for an "idle" or "valid" status
  • Update invalid styling to a 2px bottom border, for instance (example below):
image

Figma resources

image

See the Figma file for development implementation.

Relevant Info

#4598

Which Component

select

Example Use Case

Validation

Priority impact

p2 - want for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (design)

@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. ready for dev Issues ready for development implementation. labels Jul 21, 2023
@github-actions github-actions bot added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. labels Jul 21, 2023
@github-actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 26, 2023
@geospatialem geospatialem added this to the 2023 November Priorities milestone Jul 26, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
@geospatialem
Copy link
Member Author

Closing in favor of the efforts completed in #8057, where the status property was added, along with an internal input-message for displaying validation messages.

Additional efforts will be completed in #8000 for setting the validity state of the component internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

2 participants