Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[calcite-input-date-picker] add status prop #5208

Closed
joeyHarig opened this issue Aug 23, 2022 · 7 comments
Closed

[calcite-input-date-picker] add status prop #5208

joeyHarig opened this issue Aug 23, 2022 · 7 comments
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. low risk Issues with low risk for consideration in low risk milestones p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Milestone
Stalled

Comments

@joeyHarig
Copy link
Contributor

joeyHarig commented Aug 23, 2022 •
edited
Loading

Description

Add a status prop to the calcite-input-date-picker component that would behave the same as the status prop on calcite-input.

Screen Shot 2022-08-23 at 2 08 27 PM

Acceptance Criteria

same as the status prop on calcite-input

Relevant Info

No response

Which Component

calcite-input-date-picker

Example Use Case

No response
@joeyHarig joeyHarig added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Aug 23, 2022
@jarknight
Copy link

The Business Analyst team would also like to see this implemented. The input-time-picker could benefit from having status added as well. All other input components have this property.

@eriklharper eriklharper mentioned this issue Nov 9, 2022
Closed
@jcfranco jcfranco mentioned this issue Nov 10, 2022
Open
@jcfranco
Copy link
Member

Linked to validation epic. cc @geospatialem

@geospatialem geospatialem added design Issues that need design consultation prior to development. ready for dev Issues ready for development implementation. p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Jul 21, 2023
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 21, 2023
@github-actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem
Copy link
Member

See the Figma file for implementation:

image

@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 26, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@brittneytewks brittneytewks added the low risk Issues with low risk for consideration in low risk milestones label Sep 21, 2023
@jcfranco
Copy link
Member

@benelan Do you have bandwidth to pick this up this week?

@geospatialem geospatialem added the blocked This issue is blocked by another issue. label Oct 27, 2023
@geospatialem
Copy link
Member

This issue is blocked by the efforts of #8057 and #8000, which are targeted for late 2023.

@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
@geospatialem
Copy link
Member

Closing in favor of the efforts completed in #8057, where the status property was added, along with an internal input-message for displaying validation messages.

Additional efforts will be completed in #8000 for setting the validity state of the component internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. low risk Issues with low risk for consideration in low risk milestones p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
Stalled
Development

No branches or pull requests
6 participants
@jcfranco @alisonailea @geospatialem @joeyHarig @jarknight @brittneytewks