Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic: setFocus method should focus on the component's first focusable element #5132

Closed
8 tasks
geospatialem opened this issue Aug 10, 2022 · 2 comments
Closed
8 tasks

Epic: setFocus method should focus on the component's first focusable element #5132

geospatialem opened this issue Aug 10, 2022 · 2 comments
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. breaking change Issues and pull requests with code changes that are not backwards compatible. enhancement Issues tied to a new feature or request. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. needs triage Planning workflow - pending design/dev review.

Comments

@geospatialem
Copy link
Member

Background

Remove the focusId parameter used in any setFocus methods. Components should instead focus on the first focusable element, and there should not be an available parameter option.

cc @driskull

Plan of action

  • Deprecate focusId across CC:
    • action-bar
    • action-pad
    • modal
    • panel
    • pick-list
    • popover
    • value-list
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. enhancement Issues tied to a new feature or request. breaking change Issues and pull requests with code changes that are not backwards compatible. a11y Issues related to Accessibility fixes or improvements. 0 - new New issues that need assignment. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. needs triage Planning workflow - pending design/dev review. labels Aug 10, 2022
@github-actions
Copy link
Contributor

It looks like this issue is missing some information:

Issues without reproduction samples may not be prioritized. If you were unable to create a sample, please try to answer any questions that arise once development begins. Thanks for your understanding.

@github-actions github-actions bot added the incomplete issue report New issues missing important information, and unless provided, they will be closed after 5 days. label Aug 10, 2022
@benelan benelan removed bug Bug reports for broken functionality. Issues should include a reproduction of the bug. incomplete issue report New issues missing important information, and unless provided, they will be closed after 5 days. labels Aug 10, 2022
@jcfranco jcfranco mentioned this issue Aug 13, 2022
Open
7 tasks
@geospatialem
Copy link
Member Author

Closing in favor of #5147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. breaking change Issues and pull requests with code changes that are not backwards compatible. enhancement Issues tied to a new feature or request. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geospatialem @benelan