Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add Empty State slot to calcite-pick-list #4446

Closed
Tracked by #5529
joeyHarig opened this issue Apr 25, 2022 · 2 comments
Closed
Tracked by #5529

Enhancement: Add Empty State slot to calcite-pick-list #4446

joeyHarig opened this issue Apr 25, 2022 · 2 comments
Labels
0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. has workaround Issues have a workaround available in the meantime. needs triage Planning workflow - pending design/dev review.

Comments

@joeyHarig
Copy link
Contributor

Description

Add a slot for developers to implement an empty state when a filter enabled calcite-pick-list returns no results.

Acceptance Criteria

  • Add slot for an empty state to calcite-pick-list

Relevant Info

No response

Which Component

calcite-pick-list

Example Use Case

Developers may want to add info such as 'no items found' or actions to create additional options when no options match the search string.

@joeyHarig joeyHarig added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Apr 25, 2022
@macandcheese
Copy link
Contributor

macandcheese commented Jul 4, 2022

Can you conditionally display an element when there are no results?
It's confusing to use since the event comes from the internal filter, and you need to infer what items are displayed:

Something like this: https://codesandbox.io/s/green-wave-bgulis?file=/src/App.js

@jcfranco @benelan - it's hard to tell you can even use the filter events through the list. Maybe we can update doc?

@geospatialem geospatialem added this to the 2023 January Priorities milestone Dec 2, 2022
@geospatialem geospatialem added the has workaround Issues have a workaround available in the meantime. label Dec 7, 2022
@geospatialem geospatialem removed this from the 2023 January Priorities milestone Dec 7, 2022
@geospatialem
Copy link
Member

With the calcite-list component refactor, we won't be adding additional enhancements to the calcite-pick-list at this time. The component refactor includes a filter which can listen for results.

The workaround from @macandcheese above has a workaround.

Closing the issue for the above refactor for next month's release and workaround prior to the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. has workaround Issues have a workaround available in the meantime. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants