Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

game-scanner cannot be compiled on Windows with Rust 1.69 #110

Open
GeckoEidechse opened this issue Apr 21, 2023 · 1 comment · May be fixed by #111
Open

game-scanner cannot be compiled on Windows with Rust 1.69 #110

GeckoEidechse opened this issue Apr 21, 2023 · 1 comment · May be fixed by #111

Comments

@GeckoEidechse
Copy link

GeckoEidechse commented Apr 21, 2023 •
edited
Loading

With Rust 1.69 some logic in ntapi is considered no longer supported and as such compilation fails.

Expected Behavior

game-scanner fails to compile with Rust 1.69 due to one of its dependencies being outdated.

Current Behavior

game-scanner should compile fine on Rust 1.69

Possible Solution

Merge #109

Steps to Reproduce (for bugs)

  1. Build any project that has game-scanner = "1.1.4" in it's Cargo.toml with Rust 1.69 on Windows

Context

I'm using game-scanner as a dependency for my modding tool: https://github.com/R2NorthstarTools/FlightCore/

I noticed a recent CI run failing and started investigating the issue.

Failing CI run: https://github.com/R2NorthstarTools/FlightCore/actions/runs/4756368935/jobs/8458495132#step:8:722

Your Environment
@GeckoEidechse GeckoEidechse mentioned this issue Apr 21, 2023
Closed
@GeckoEidechse
Copy link
Author

GeckoEidechse commented Apr 21, 2023 •
edited
Loading

Confirmed that #109 fixes the issue via https://github.com/R2NorthstarTools/FlightCore/actions/runs/4765073012

@ShayBox ShayBox linked a pull request Aug 10, 2023 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated dependencies Shays-Forks/game-scanner
1 participant
@GeckoEidechse