Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Admins" Text Channel (LegacyChatService) #1596

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

PurpleCreativity
Copy link
Contributor

  • Adds an "Admins" text channel IF the current chat version is the legacy one
  • Adds Events.AdminAdded and Events.AdminRemoved

PoF:
https://github.com/user-attachments/assets/17cd6611-d71d-4e17-8d77-62b725fef346
https://discord.com/channels/81902207070380032/944715691477594172/1281356059210027058
(file size was too big)

@PurpleCreativity
Copy link
Contributor Author

(debug prints were removed)

@Dimenpsyonal Dimenpsyonal added the ✨ enhancement Enhancing or improving existing functionality label Sep 6, 2024
@EasternBloxxer
Copy link
Contributor

This is not that useful as exploiters can literally just log any message sent by anyone in there.

On this screenshot Player2 has ran a script on their client that prints out any message sent in the chat. This includes the admin only chat.
image
Just make your own chat UI for admins like PRIDe/EISS had

@PurpleCreativity
Copy link
Contributor Author

This is not that useful as exploiters can literally just log any message sent by anyone in there.

On this screenshot Player2 has ran a script on their client that prints out any message sent in the chat. This includes the admin only chat. image Just make your own chat UI for admins like PRIDe/EISS had

Its for legacy chat (which is deprecated), i plan to add this for the new chat when roblox makes it support channels

@EasternBloxxer
Copy link
Contributor

there should still be a note or a warning about it somewhere that exploiters can see the messages sent in there

@PurpleCreativity
Copy link
Contributor Author

there should still be a note or a warning about it somewhere that exploiters can see the messages sent in there

you mean like in the channel welcomemessage or smth?

@ccuser44
Copy link
Contributor

there should still be a note or a warning about it somewhere that exploiters can see the messages sent in there

you mean like in the channel welcomemessage or smth?

Yes.

@PurpleCreativity
Copy link
Contributor Author

@EasternBloxxer
Copy link
Contributor

This can be closed as it is for a soon to be removed legacy system

@ccuser44
Copy link
Contributor

ccuser44 commented Nov 3, 2024

This can be closed as it is for a soon to be removed legacy system

I don't think we should totally remove support for legacychat service though. Many people have custom chatsystems tgat are deratives. I say we should totally re-write how Adonis handles chat as there are multiple issues with the current implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement Enhancing or improving existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants