Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacktrace when executing oríon without arguments #328

Closed
Thomsch opened this issue Feb 3, 2020 · 6 comments
Closed

Stacktrace when executing oríon without arguments #328

Thomsch opened this issue Feb 3, 2020 · 6 comments
Labels
bug Indicates an unexpected problem or unintended behavior good first issue Indicates a good issue for first-time contributors medium The bug breaks a feature but it can still be used or causes a confusing user experience

Comments

@Thomsch
Copy link
Contributor

Thomsch commented Feb 3, 2020

When executing orion without arguments, I get a stacktrace:

~$ orion
Traceback (most recent call last):
  File "/home/thomsch/venv/pycharm/bin/orion", line 10, in <module>
    sys.exit(main())
  File "/home/thomsch/venv/pycharm/lib/python3.7/site-packages/orion/core/cli/__init__.py", line 39, in main
    orion_parser.execute(argv)
  File "/home/thomsch/venv/pycharm/lib/python3.7/site-packages/orion/core/cli/base.py", line 73, in execute
    args, function = self.parse(argv)
  File "/home/thomsch/venv/pycharm/lib/python3.7/site-packages/orion/core/cli/base.py", line 67, in parse
    function = args.pop('func')
KeyError: 'func'

The expected behavior is to execute a default behaviour (for example ls lists the files and folder in the current directory) or show a helpful message to the user, usually the content of --help.

In orion's context, I believe showing the help would be the most appropriate action to execute.

@Thomsch Thomsch added bug Indicates an unexpected problem or unintended behavior good first issue Indicates a good issue for first-time contributors v0.1.7 labels Feb 3, 2020
@Thomsch
Copy link
Contributor Author

Thomsch commented Feb 3, 2020

@Thomsch
Copy link
Contributor Author

Thomsch commented Feb 5, 2020

This indesirable behaviour is also present for the following subcommands:

  • init_only
  • hunt
  • db
  • insert
  • info

@Thomsch Thomsch removed the v0.1.7 label May 26, 2020
@Thomsch
Copy link
Contributor Author

Thomsch commented Jun 8, 2020

2 similar comments
@Thomsch
Copy link
Contributor Author

Thomsch commented Jun 8, 2020

@Thomsch
Copy link
Contributor Author

Thomsch commented Jun 8, 2020

@Thomsch Thomsch added the medium The bug breaks a feature but it can still be used or causes a confusing user experience label Jun 12, 2020
@Thomsch
Copy link
Contributor Author

Thomsch commented Jun 19, 2020

Fixed in #408

@Thomsch Thomsch closed this as completed Jun 19, 2020
This was referenced Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior good first issue Indicates a good issue for first-time contributors medium The bug breaks a feature but it can still be used or causes a confusing user experience
Projects
None yet
Development

No branches or pull requests

1 participant