Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow support for FloatingUI #2640

Closed
2 tasks done
oschleic opened this issue Aug 29, 2022 · 1 comment
Closed
2 tasks done

Allow support for FloatingUI #2640

oschleic opened this issue Aug 29, 2022 · 1 comment

Comments

@oschleic
Copy link
Contributor

oschleic commented Aug 29, 2022

Prerequisites

Proposal

Remove the requirement for popperJS and add support for using FloatingUI.

I have a partial implementation here.

Motivation and context

I'd like to be able to directly use this library, without the requirement of popperJS. One possible solution would be to make popperJS an optional peer dependency, and allow for custom handling of the "popperInstance" in the implementation. It will allow for more granular control in the implementation while still allowing for default behavior to be implemented using popperJS.

For more info on migrations see https://floating-ui.com/docs/migration

@oschleic oschleic changed the title Migrate from popperJS to FloatingUI Allow support for FloatingUI Aug 29, 2022
@Eonasdan
Copy link
Owner

I have looked at floating ui and I do want to move to it at some point. Well bootstrap is no longer a dependency, I'm guessing that's where most people are using it. BS5 moved to popper 2 and they have opened tickets to migrate as well. If I simply migrate now, most people will have yet another dependency.

I would consider a PR that hide the implementation that defaulted to popper but could be overwritten in a plugin to use floating ui or w/e. That's probably the way forward anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants