Make IMPORT FOREIGN SCHEMA behave consistently

mhw · mhw · commit c55ec1eb1850 · 2020-10-14T16:45:10.000+01:00
The case of the table names returned by information_schema queries depends on MySQL's `lower_case_table_names` setting. https://dev.mysql.com/doc/refman/5.7/en/charset-collation-information-schema.html suggests forcing a suitable collation to work around the issue. Fixes #202.
diff --git a/mysql_fdw.c b/mysql_fdw.c
@@ -1774,7 +1774,7 @@ mysqlImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid)
 	{
 		bool		first_item = true;
 
-		appendStringInfoString(&buf, " AND t.TABLE_NAME ");
+		appendStringInfoString(&buf, " AND t.TABLE_NAME COLLATE UTF8_GENERAL_CI ");
 		if (stmt->list_type == FDW_IMPORT_SCHEMA_EXCEPT)
 			appendStringInfoString(&buf, "NOT ");
 		appendStringInfoString(&buf, "IN (");

Original file line number	Diff line number	Diff line change
`@@ -1774,7 +1774,7 @@ mysqlImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid)`
`1774`	`1774`	`{`
`1775`	`1775`	`bool first_item = true;`
`1776`	`1776`
`1777`		`- appendStringInfoString(&buf, " AND t.TABLE_NAME ");`
	`1777`	`+ appendStringInfoString(&buf, " AND t.TABLE_NAME COLLATE UTF8_GENERAL_CI ");`
`1778`	`1778`	`if (stmt->list_type == FDW_IMPORT_SCHEMA_EXCEPT)`
`1779`	`1779`	`appendStringInfoString(&buf, "NOT ");`
`1780`	`1780`	`appendStringInfoString(&buf, "IN (");`