Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you also add support for static libraries? #68

Closed
web3creator opened this issue May 28, 2023 · 6 comments
Closed

Can you also add support for static libraries? #68

web3creator opened this issue May 28, 2023 · 6 comments

Comments

@web3creator
Copy link

hello,Can you also add support for static libraries?

@Enet4
Copy link
Owner

Enet4 commented May 29, 2023

Hello! There was an attempt at supporting static linking not long ago (#67). It was probably working for the most of it, but the original author seemingly gave up on it before I could get the time to fully review it. If someone is willing to commandeer the contribution, we can try bringing it upstream again.

@web3creator
Copy link
Author

I referred to the implementation of https://github.com/rust-rocksdb/rust-rocksdb, but there are many problems, I don't know C language, I am learning and hope to contribute to the system

@SkyFan2002
Copy link
Contributor

I referred to the implementation of https://github.com/rust-rocksdb/rust-rocksdb, but there are many problems, I don't know C language, I am learning and hope to contribute to the system

Thank you for your efforts on this feature. I open the PR again. Hope my implementation can solve part of your problem. I have an idea, can we cooperate on this?

@web3creator
Copy link
Author

@SkyFan2002 of course

@Enet4
Copy link
Owner

Enet4 commented Aug 26, 2023

Baseline support for static linking has just dropped with version 0.12.1 (#69 and #70). Extending this to support more options (e.g. avx2 target) may be done in future releases.

@Enet4 Enet4 closed this as completed Aug 26, 2023
@jondot
Copy link

jondot commented Aug 28, 2023

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants