Remove GridArea 870 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REmove this grid area as it is assignet only to an Energinet Datahub Actor, which has the role DDZ, which shouldn't be assigned gridareas.
FirestarJes
requested review from
xnetsrak,
defectiveAi,
mbusk88 and
michaelmajgaard
BjarkeMeier
reviewed
Feb 2, 2022
| @@ -0,0 +1,2 @@ | |||
| DELETE FROM GridAreaInfo | |||
| WHERE Id = 'CBB32B7B-1644-4B8C-AAC4-5EE8E862F4F8' AND Code = '870' | |||
There was a problem hiding this comment.
Can you remove the grid area without first removing the link?
There was a problem hiding this comment.
You are right, updated scripts
There was a problem hiding this comment.
Perhaps it would make sense to add an integration test? We have some repository tests in the charges domain that could serve as a good inspiration.
There was a problem hiding this comment.
In the long term, that may very well be a good idea. But it's not currently planned.
BjarkeMeier
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove this grid area as it is assigned only to an Energinet Datahub Actor, which has the role DDZ, which shouldn't be assigned gridareas.