[1.12.2] Experience Rate is missing a lang key (Maybe others?) & Attribute Name change.

[SonicX8000]

1. The generic.experienceRate is an attribute that increases the rate of xp that you get from orbs... it be from slain mobs or from ores, etc.

Now... since this is an attribute, it can be used by mods like Quality Tools, Set Bonus, etc, though there's a missing lang key for it and it reads it as attribute.name.generic.experienceRate. It prob should be called Experience Rate since it affects the drop amount for the XP Orbs. Here's what it looks like on quality tools.

Unsure if the other attribute names are missing a lang key, it's been awhile and I'll have to mess with quality tools and add them in as a test quality.

---

2. This is prob outside the scope, but I noticed that the attributes from Soot have the word generic in their names. This is usually a vanilla attribute name and this doesn't really affected anything but it might be better to name the attribute based on the mod name, at least from what I seen from other mods that add in attributes (See Potioncore, their names are potioncore.projectileDamage, potioncore.magicShielding, etc for their attributes.)

The affected attribute names are...

(Soot)
`generic.physicalDamageRate`
`generic.experienceRate`
`generic.fireDamageRate`
`generic.fireAspect`
`generic.barehandedPower`
`generic.witchburn`
`generic.attraction`
`generic.attraction_generation`

You could change them to...

`soot.physicalDamageRate`
`soot.experienceRate`
`soot.fireDamageRate`
`soot.fireAspect`
`soot.barehandedPower`
`soot.witchburn`
`soot.attraction`
`soot.attraction_generation`

...just so it's known that said attribute was from Soot. When I first saw these I though they were part of the vanilla attributes like generic.maxHealth, generic.attackDamage, generic.armor, etc. I dunno if the name change would break anything though.

P.S.
Also... if you happen to know... what do the other attributes from Soot do? I know that Physical Damage Rate affects physical-like damage that you take. Fire Damage rate affects how much fire-like damage you take, at least from what I've checked with Quality Tools back then.

[MasterEnderman]

Thanks for your feedback! I'll definitely look into changing and localizing the attributes (remember that renaming them to soo replaces them so every item that currently has one of those attributes may appear broken or something.
I haven't explored all of the attributes myself yet, but feel free to ponder in this class. Furthermore feel free to hit me up on discord, I may be able to send you a dev build to test these changes if you want. :)