-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for denying crates with executables or specific file extensions #43
Comments
though now very recently the very popular so this issue is still relevant |
They did this in prost-build 0.10 but as far as I know prost-build 0.11 requires protoc installed prior (I know this because I had to fix my docker images to support this, both with the cmake build in 0.10, and with the no cmake version in 0.11) prost no longer bundles anything |
Yeah, proto-gen doesn't solve the bundling issue, it's just a smooth(-ish) way of generating the Rust-code and checking that it's up to date with the proto-files, one still needs to wrangle protoc, but only if you want to update protos. That's nice because if you have someone who wants to edit unrelated stuff they generally don't have to bother with protoc. It's does create a bit of a mess since generated files are checked in, but on the positive side it removes the need for a build.rs and tonic build as a direct dependency. It also plays nicer with editors which has been a plus! |
Some crates like
prost-derive
include embedded executables that they run inbuild.rs
, this works on the main dev platforms but something we would like to have pure Rust versions of and deny.@LucioFranco also mentioned that it could be useful to be able to deny crates with specific file extensions in it, which could be part of the same feature.
This would require some scanning and wouldn't be fool proof because a crate could still contain say a zipped exe that it unpacks or simply download an exe and run it in build.rs. But can be good to investigate still
The text was updated successfully, but these errors were encountered: