Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check changed dependencies #411

Open
RyanMeulenkamp opened this issue Mar 21, 2022 · 0 comments
Open

Only check changed dependencies #411

RyanMeulenkamp opened this issue Mar 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@RyanMeulenkamp
Copy link

RyanMeulenkamp commented Mar 21, 2022

Is your feature request related to a problem? Please describe.

For our CI we would like to split checking the dependencies over two periods:

  • Changed dependencies before merging the PR
  • Existing dependencies at an interval (e.g. daily)

That way we don't block every open PR when a security issue pops up, but we still prevent a PR from merging if it introduces a bad dependency.

I can see a few different approaches to this problem. I'm totally open to suggestions here. I can´t imagine this CI strategy is unique to us so maybe someone has already implemented something like this.

Describe the solution you'd like
The nicest solution from the user's perspective would be to simply have an argument, say --changed-since, to which you can pass a git reference, and it only takes those dependencies into account.

Describe alternatives you've considered
Two other possible solutions I can see:

  • (this might be possible already): allow passing a list to the CLI of what dependencies to consider. Takes some additional interpretation work from the user's side to list all the dependencies, from the Cargo.toml's that were changed since a certain point in time.
  • Add this feature to the Github Action.
@RyanMeulenkamp RyanMeulenkamp added the enhancement New feature or request label Mar 21, 2022
@RyanMeulenkamp RyanMeulenkamp changed the title Only check newly added dependencies Only check changed dependencies Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant