Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect unused deny wrappers use cases #405

Closed
repi opened this issue Feb 12, 2022 · 0 comments · Fixed by #590
Closed

Detect unused deny wrappers use cases #405

repi opened this issue Feb 12, 2022 · 0 comments · Fixed by #590
Labels
enhancement New feature or request

Comments

@repi
Copy link
Contributor

repi commented Feb 12, 2022

We had an exemption of a crate deny rule for another crate that still needed it, which we used the wrappers field for (a bit hacky), like this:

deny = [
    { name = "inventory", wrappers = [ "tract-pulse", "tract-pulse-opl" ] }, # disallow these crates that rely on static initialization order which we've had issues with. tract needs it though.
]

but a later version of those tract-* crates had then finally removed the dependency on inventory and it was no longer reference in our Cargo.lock but we didn't know. Would be nice if cargo-deny would have logged out a warning about an unused wrappers field here for the crates so one can get a heads up and remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant