Skip to content

Commit 231f77b

Browse files
committed
Explain the use of jenseng/dynamic-uses
1 parent 9debbae commit 231f77b

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,14 @@ jobs:
257257
steps:
258258
- name: Upgrade Git for Windows
259259
# TODO(ci): Don't run this step once `windows-11-arm` ships a new enough Git.
260-
# The Windows 11 ARM runner still ships Git 2.48.*, so it remains affected by #1849.
260+
# The Windows 11 ARM runner still ships Git 2.48.*, so it remains affected by #1849. So we
261+
# upgrade to the latest stable Git for Windows. We do this before `actions/checkout` for
262+
# two reasons: so `actions/checkout` will itself use the new Git, verifying that it works,
263+
# and so no dangling subprocess from the old Git will prevent the Inno Setup installer from
264+
# replacing its files. We can't run our `upgrade-git-for-windows` composite action with a
265+
# `./` path, because it has not been checked out. But we also want to use any changes that
266+
# have just been made to it, so we specify the current repo and commit. But the `github`
267+
# context is unavailable in `uses`, so we do this indirectly via the `dynamic-uses` action.
261268
if: matrix.os == 'windows-11-arm'
262269
uses: jenseng/dynamic-uses@v1
263270
with:

0 commit comments

Comments
 (0)