File tree Expand file tree Collapse file tree 1 file changed +8
-1
lines changed Expand file tree Collapse file tree 1 file changed +8
-1
lines changed Original file line number Diff line number Diff line change @@ -257,7 +257,14 @@ jobs:
257257 steps :
258258 - name : Upgrade Git for Windows
259259 # TODO(ci): Don't run this step once `windows-11-arm` ships a new enough Git.
260- # The Windows 11 ARM runner still ships Git 2.48.*, so it remains affected by #1849.
260+ # The Windows 11 ARM runner still ships Git 2.48.*, so it remains affected by #1849. So we
261+ # upgrade to the latest stable Git for Windows. We do this before `actions/checkout` for
262+ # two reasons: so `actions/checkout` will itself use the new Git, verifying that it works,
263+ # and so no dangling subprocess from the old Git will prevent the Inno Setup installer from
264+ # replacing its files. We can't run our `upgrade-git-for-windows` composite action with a
265+ # `./` path, because it has not been checked out. But we also want to use any changes that
266+ # have just been made to it, so we specify the current repo and commit. But the `github`
267+ # context is unavailable in `uses`, so we do this indirectly via the `dynamic-uses` action.
261268 if : matrix.os == 'windows-11-arm'
262269 uses : jenseng/dynamic-uses@v1
263270 with :
You can’t perform that action at this time.
0 commit comments