Commit fc755da
committed
Avoid having a local function seem to be a method
The kill_process local function defined in the Git.execute method
is a local function and not a method, but it was easy to misread as
a method for two reasons:
- Its docstring described it as a method.
- It was named with a leading underscore, as though it were a
nonpublic method. But this name is a local variable, and local
variables are always nonpublic (except when they are function
parameters, in which case they are in a sense public). A leading
underscore in a local variable name usually means the variable is
unused in the function.
This fixes the docstring and drops the leading underscore from the
name. If this is ever extracted from the Git.execute method and
placed at class or module scope, then the name can be changed back.1 parent 133271b commit fc755da
1 file changed
+3
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1012 | 1012 | | |
1013 | 1013 | | |
1014 | 1014 | | |
1015 | | - | |
1016 | | - | |
| 1015 | + | |
| 1016 | + | |
1017 | 1017 | | |
1018 | 1018 | | |
1019 | 1019 | | |
| |||
1046 | 1046 | | |
1047 | 1047 | | |
1048 | 1048 | | |
1049 | | - | |
| 1049 | + | |
1050 | 1050 | | |
1051 | 1051 | | |
1052 | 1052 | | |
| |||
0 commit comments