Fix node announce self-advertize and advertize both sides of channels #6412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex and I were reading it and I got confused: it's really a simpler loop than it seems, with all those redundant `continue` statements. Signed-off-by: Rusty Russell <[email protected]>
We do this as suggested by the spec: send our own gossip even if they didn't ask for it. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/fix-node-announce-on-connect
branch
from
34f018c to
57dfdb0
Compare
endothermicdev
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
It's nice to make sure the node_announcements actually get out into the world. Thanks for the quick resolution to this bug report.
ACK 57dfdb0
gossipd/gossipd.c
Outdated
| } | ||
|
|
||
| /* If we announced a channel, we should send our own node_announcement */ | ||
| if (announced_channels && me->bcast.index) |
There was a problem hiding this comment.
It might be better to leave out the announced_channels flag. I can't think of a scenario where it results in a different outcome than relying on the existence of our node_announcement. Maybe it's useful once there's a spliced channel in progress if we wanted to stop gossiping about it in the interim?
There was a problem hiding this comment.
Hmm, good thinking! Any failure is weird, and it can't hurt. I'll remove the flag...
@endothermicdev and I found this while investigating a "nobody sees my node_announcement" bug report. Signed-off-by: Rusty Russell <[email protected]> Fixes: ElementsProject#6410 Reported-by: benjaminchodroff on discord Changelog-Fixed: Protocol: When we send our own gossip when a peer connects, send our node_announcement too (regression in v23.05)
While one side was not produced by us, we have a vested interest in propagating it. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Protocol: When we send our own gossip when a peer connects, also send any incoming channel_updates.
rustyrussell
force-pushed
the
guilt/fix-node-announce-on-connect
branch
from
57dfdb0 to
4008452
Compare
|
ACK 4008452 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@endothermicdev investigated this, and we diagnosed together. It's a regression introduced in v23.05 when we moved "gossip blast" from gossip store into gossipd.
Through the glory of tests, we also fixed a similar issue where we didn't send incoming channel_updates: we never did, but it's a good thing to do!
Fixes: #6410