lightningd: Look for channels by alias when finding channels #5846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ack f61cf34 Good patch! Please add to the commit message: |
dongcarl
force-pushed
the
2022-12-find_channel-consider-aliases
branch
from
f61cf34 to
008a9dc
Compare
|
Done! |
When a channel is not yet confirmed onchain and only has an alias, `getroute` will return the alias under the "channel" key. However, if you supply that to `sendpay`, it will not be able to find the channel and will fail since it calls `find_channel_for_htlc_add` and that only looks for channels by their scid and doesn't consider their alias. This patch makes `find_channel_for_htlc_add` also consider channel aliases when looking for channels. Changelog-Fixed: JSON-RPC: `sendpay` now can send to a short-channel-id alias for the first hop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a channel is not yet confirmed onchain and only has an alias,
getroutewill (arguably correctly) return the alias under the "channel" key. However, if you supply that tosendpay, it will not be able to find the channel and will fail since it callsfind_channel_for_htlc_addand that only looks for channels by their scid and doesn't consider their aliases.This patch makes
find_channel_for_htlc_addalso consider channel aliases when looking for channels.Partly resolves #5803, but not entirely.