Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequencer :forget() does not properly work with DataParallelTable #404

Open
achalddave opened this issue Mar 13, 2017 · 0 comments
Open

Comments

@achalddave
Copy link
Contributor

achalddave commented Mar 13, 2017

I am filing this primarily for documentation: As mentioned in torch/cunn#233, the nn.Sequencer's :forget method (and possibly other methods) do not work properly with nn.DataParallelTable, as they only apply to the model on the first GPU.

I'm not sure what the cleanest way to fix this in the RNN library is. One option is to define a :forget() method on DataParallelTable, but the simplest way of doing that would introduce a dependency on cunn which would not be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant