Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humble development container fails to build beluga_vdb when following instructions in DEVELOPING.md #474

Open
glpuga opened this issue Feb 14, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@glpuga
Copy link
Collaborator

glpuga commented Feb 14, 2025

Bug description

The repository fails to build beluga_vdb when using the ROS Humble image, doing:

. /opt/ros/${ROS_DISTRO}/setup.bash
cd /ws
colcon build --symlink-install

as per DEVELOPING.md instructions.

Image

Platform (please complete the following information):

  • OS: [e.g. Ubuntu Focal]
  • Beluga version: [e.g. tag, commit sha]

How to reproduce

Start docker humble container, and do:

. /opt/ros/${ROS_DISTRO}/setup.bash
cd /ws
colcon build --symlink-install

Expected behavior

All packages build cleanly.

Actual behavior

Image

Additional context

@glpuga glpuga added the bug Something isn't working label Feb 14, 2025
@glpuga
Copy link
Collaborator Author

glpuga commented Feb 14, 2025

@hidmic should this package build in Humble?

@hidmic
Copy link
Collaborator

hidmic commented Feb 14, 2025

It would if OpenVDB was properly packaged on Jammy. It's not. Thus why:

if [ "${ROS_DISTRO}" != "humble" ] && [ "${ROS_DISTRO}" != "iron" ]; then
ROS_PACKAGES="beluga beluga_ros beluga_amcl beluga_system_tests beluga_tools beluga_vdb"
fi

only builds it for Noble. We can do better than this though. We could build and install it from source from within the container.

Anyways, yes, we missed updating DEVELOPING.md when #440 went in.

@hidmic
Copy link
Collaborator

hidmic commented Feb 14, 2025

Hmm, after some thought, I think the proper solution here (other than branching, which I'd very much try to avoid) is to:

  • Install from OpenVDB from sources within the Jammy container.
  • Add instructions on how to install OpenVDB from sources on Jammy (in the beluga_vdb README)
  • Add a note in DEVELOPING.md about skipping beluga_vdb builds unless either of the above are satisfied (using COLCON_IGNORE or else)

FYI @pvela2017

@pvela2017
Copy link
Contributor

Hmm, after some thought, I think the proper solution here (other than branching, which I'd very much try to avoid) is to:

  • Install from OpenVDB from sources within the Jammy container.
  • Add instructions on how to install OpenVDB from sources on Jammy (in the beluga_vdb README)
  • Add a note in DEVELOPING.md about skipping beluga_vdb builds unless either of the above are satisfied (using COLCON_IGNORE or else)

FYI @pvela2017

Hi!

I can work on this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants