Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit recovery algorithm implementation #318

Open
hidmic opened this issue Feb 9, 2024 · 0 comments
Open

Revisit recovery algorithm implementation #318

hidmic opened this issue Feb 9, 2024 · 0 comments
Labels
cpp Related to C++ code enhancement New feature or request

Comments

@hidmic
Copy link
Collaborator

hidmic commented Feb 9, 2024

Feature description

#279 uncovered a few discrepancies between our implementation of the particle degeneracy recovery algorithm and that of Nav2 AMCL. We should revisit both control flow and normalization factors in our implementation.

Implementation considerations

Some notes and hints that may be relevant:

  • Make sure to update the probability estimator every time we propagate
  • Compare normalization using distribution mass, mean, and max.
  • Consider grabbing weights before multiplicative integration.
@hidmic hidmic added enhancement New feature or request cpp Related to C++ code labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ code enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant