Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tests #10

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Rename tests #10

merged 1 commit into from
Oct 7, 2024

Conversation

x-hgg-x
Copy link
Contributor

@x-hgg-x x-hgg-x commented Oct 1, 2024 •
edited
Loading

Use test names from rust-lang/cargo#14614.

@x-hgg-x x-hgg-x mentioned this pull request Oct 1, 2024
Merged
Eh2406
Eh2406 requested changes Oct 1, 2024
View reviewed changes
Copy link
Owner

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this and for the improvements to naming and readability!

Eh2406
Eh2406 requested changes Oct 7, 2024
View reviewed changes
Copy link
Owner

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to leave this comment last week as part of my review. Unfortunately, GitHub seems to have eaten it. :-(
Sorry for the additional unnecessary delay.

src/tests.rs Show resolved Hide resolved
src/tests.rs Show resolved Hide resolved
Eh2406
Eh2406 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Owner

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is much clearer!

@Eh2406 Eh2406 merged commit 0f6f442 into Eh2406:main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eh2406 Eh2406 Eh2406 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@x-hgg-x @Eh2406