Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hot-walls-share.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect/language-service": patch
---

Fix the class self mismatch diagnostic so it also reports invalid `ServiceMap.Service` self type parameters.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// code fix classSelfMismatch_fix output for range 317 - 328
import { ServiceMap, Effect } from "effect"

export class CorrectName extends ServiceMap.Service<CorrectName, {
writeCache: () => Effect.Effect<void, never, FileSystem | Cache>
readCache: Effect.Effect<void, never, FileSystem | Cache>
}>()("CorrectName") {}

export class WrongName extends ServiceMap.Service<WrongName, {
writeCache: () => Effect.Effect<void, never, FileSystem | Cache>
readCache: Effect.Effect<void, never, FileSystem | Cache>
}>()("WrongName") {}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
classSelfMismatch_fix from 317 to 328
classSelfMismatch_skipNextLine from 317 to 328
classSelfMismatch_skipFile from 317 to 328
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
CorrectName
8:50 - 8:61 | 1 | Self type parameter should be 'WrongName' effect(classSelfMismatch)
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { ServiceMap, Effect } from "effect"

export class CorrectName extends ServiceMap.Service<CorrectName, {
writeCache: () => Effect.Effect<void, never, FileSystem | Cache>
readCache: Effect.Effect<void, never, FileSystem | Cache>
}>()("CorrectName") {}

export class WrongName extends ServiceMap.Service<CorrectName, {
writeCache: () => Effect.Effect<void, never, FileSystem | Cache>
readCache: Effect.Effect<void, never, FileSystem | Cache>
}>()("WrongName") {}
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export const classSelfMismatch = LSP.createDiagnostic({
// Check if this class extends a class that has a Self type parameter
const result = yield* pipe(
typeParser.extendsEffectService(node),
Nano.orElse(() => typeParser.extendsServiceMapService(node)),
Nano.orElse(() => typeParser.extendsContextTag(node)),
Nano.orElse(() => typeParser.extendsEffectTag(node)),
Nano.orElse(() => typeParser.extendsSchemaClass(node)),
Expand Down
Loading