Skip to content

Commit

Permalink
Remove extraneous todos
Browse files Browse the repository at this point in the history
  • Loading branch information
EdmundGoodman committed Mar 11, 2024
1 parent 35ed8b3 commit 3bbff96
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
1 change: 0 additions & 1 deletion src/hpc_multibench/test_bench.py
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,6 @@ def get_run_outputs(
reconstructed_run_configurations.append(rerun_group)

# Collect outputs from the run configurations
# TODO: Add async wait for incomplete jobs
run_outputs: list[dict[int, tuple[RunConfiguration, str | None]]] = [
{
job_id: (run_configuration, run_configuration.collect(job_id))
Expand Down
5 changes: 1 addition & 4 deletions src/hpc_multibench/tui/interactive_ui.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def compose(self) -> ComposeResult:
with Center(id="run-dialog"):
yield Label(
(
"**Waiting for queued jobs to complete.**\n\n"
"[bold]Waiting for queued jobs to complete.[/bold]\n\n"
"You can continue, but may need to reload the test plan "
"once they are complete to see any new results."
),
Expand Down Expand Up @@ -163,7 +163,6 @@ class UserInterface(App[None]):
("m", "change_plot(-1)", "Previous Graph"),
("p", "open_graph()", "Open Graph"),
("q", "quit", "Quit"),
# TODO: Add button to reload test plan
]

def __init__( # type: ignore[no-untyped-def]
Expand Down Expand Up @@ -298,8 +297,6 @@ def update_metrics_tab(self) -> None:

def update_plot_tab(self) -> None:
"""Update the plot tab of the user interface."""
# TODO: Add button to open matplotlib window with plot as well
# TODO: Add button to cycle through plots
metrics_plot_widget = self.query_one("#metrics-plot", PlotextPlot)
metrics_plot = metrics_plot_widget.plt

Expand Down

0 comments on commit 3bbff96

Please sign in to comment.